Opened 5 years ago

Closed 5 years ago

#4381 closed defect (fixed)

Hole lies outside shell at or near point nan nan

Reported by: komzpa Owned by: pramsey
Priority: medium Milestone: PostGIS GEOS
Component: postgis Version: 2.4.x
Keywords: Cc:

Description

New GEOS does not report where is the issue with the hole outside shell:

https://debbie.postgis.net/job/PostGIS_Regress/11674/console

-----------------------------------------------------------------------------
--- tickets_expected	2019-04-20 19:31:54.555901854 +0000
+++ /var/lib/jenkins/workspace/postgis/tmp/3_0_pg10w64/test_98_out	2019-04-20 21:02:03.433352366 +0000
@@ -303,7 +303,7 @@
 #3627b|t
 #3704|t
 #3709|t
-NOTICE:  Hole lies outside shell at or near point 25495368.044100001 6671726.9312000005
+NOTICE:  Hole lies outside shell at or near point nan nan
 #3719a|f
 #3719b|t
 #3774|t
-----------------------------------------------------------------------------

Change History (4)

comment:1 by robe, 5 years ago

here is a cleaner run - https://debbie.postgis.net/job/PostGIS_Regress/11681/consoleFull

that older run also included the issue with repalloc which has since been fixed by Raul.

comment:2 by pramsey, 5 years ago

Fun, this test doesn't have the literal that causes the failure, it's generated by stroking before being sent to GEOS.

select '#3719a', ST_IsValid('CURVEPOLYGON((25495445.625 6671632.625, 25495445.625 6671711.375, 25495555.375 6671711.375, 25495555.375 6671632.625, 25495445.625 6671632.625), COMPOUNDCURVE(CIRCULARSTRING(25495368.0441 6671726.9312,25495368.3959388 6671726.93601515,25495368.7478 6671726.9333), (25495368.7478 6671726.9333,25495368.0441 6671726.9312)))');

comment:3 by pramsey, 5 years ago

Fortunately the stroked version also exercises the condition.

POLYGON((25495445.625 6671632.625,25495445.625 6671711.375,25495555.375 6671711.375,25495555.375 6671632.625,25495445.625 6671632.625),(25495368.0441 6671726.9312,25495368.3959388 6671726.93601515,25495368.7478 6671726.9333,25495368.0441 6671726.9312))

comment:4 by pramsey, 5 years ago

Resolution: fixed
Status: newclosed

Should be fixed when using the lastest master from geos, see https://trac.osgeo.org/geos/ticket/963

Note: See TracTickets for help on using tickets.