PostGIS 2.5 to 3.0 broken

[robe]

I took debbie out of the dronie line, and reran the job thinking it was a false alarm, but I'm still seeing this when it is trying to upgrade from 2.5-3.0.

What gives? ​https://dronie.osgeo.org/postgis/postgis/201/2/2

regress .. failed (diff expected obtained: /tmp/pgis_reg/test_64_diff)
-----------------------------------------------------------------------------
--- regress_expected 2019-04-07 15:23:21.077936846 +0000
+++ /tmp/pgis_reg/test_64_out 2019-04-07 15:35:25.223427766 +0000
@@ -194,3 +194,7 @@
224|
225|BOX(-6 1,3 8)
226|t
+unexpected probin|_st_asgeojson:$libdir/postgis-2.5
+unexpected probin|_st_askml:$libdir/postgis-2.5
+unexpected probin|_st_buffer:$libdir/postgis-2.5
+unexpected probin|_st_distance:$libdir/postgis-2.5
-----------------------------------------------------------------------------

I haven't tried locally to upgrade to confirm it's an issue. But seems there is a drop missing somewhere so we have old signatures from postgis-2.5 showing up

[strk]

Isn't she (Dronie) lovely ?

[strk]

The signature were dropped by Paul in r17300 Those removed signatures need to go in drop_after.sql

[strk]

In 17379:

Drop deprecated functions on upgrade

Functions were: _ST_AsGeoJson, _ST_AsKML, _ST_Distance and _ST_Buffer

They were deprecated in r17300

Fixes upgrades.
Closes #4366

[strk]

Well it is still not completely fixed: +ERROR: function st_askml(geography) is not unique at character 23 +ERROR: function st_askml(geography, integer) is not unique at character 28

Paul, can you dig why upon upgrade from 2.5 to 3.0 we are left with non-unique st_askml functions ?

[strk]

In 17380:

st_askml(geography, integer) was replaced by default args

Closes #4366 again

[strk]

Dronie is now happy: ​https://dronie.osgeo.org/postgis/postgis/206