Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#4349 closed defect (fixed)

"make check" should detect which PostgreSQL instance to use from pg_config - Part 2

Reported by: bowguy Owned by: pramsey
Priority: medium Milestone: PostGIS 3.0.0
Component: postgis Version: master
Keywords: Cc:

Description

From https://trac.osgeo.org/postgis/ticket/186

'Currently "make check" requires createdb, psql, and dropdb to be on the user's path. If more than one instance of PostgreSQL has been installed on a system this is problematic.

configure already detected which PostgreSQL instance to build against … why not prefix the binaries with BINDIR found in pg_config rather than relying on what may or may not exist in one's PATH.'

Attachments (1)

topology_path.diff (713 bytes ) - added by bowguy 5 years ago.

Download all attachments as: .zip

Change History (4)

by bowguy, 5 years ago

Attachment: topology_path.diff added

comment:1 by bowguy, 5 years ago

I ran this on Debian and worked fine. I added the code for MingW but did not test that.

comment:2 by strk, 5 years ago

Resolution: fixed
Status: newclosed

In 17339:

Ensure "make check" uses configured PostgreSQL target bins

Closes #4349
Patch by Bruce Rindahl

comment:3 by strk, 5 years ago

In 17340:

Ensure "make check" uses configured PostgreSQL target bins under regress too

References #4349

Note: See TracTickets for help on using tickets.