remove_repeated_points GCC Warning

[colivier]

FYI new GCC warning appears related to remove_repeated_points

gcc --version
i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490)
Copyright (C) 2005 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

r5283

lwgeom.c:1182: warning: no previous prototype for 'lwgeom_remove_repeated_points'
lwgeom.c: In function 'lwgeom_remove_repeated_points':
lwgeom.c:1187: warning: implicit declaration of function 'lwmpoint_remove_repeated_points'
lwgeom.c:1187: warning: return makes pointer from integer without a cast
lwgeom.c:1190: warning: implicit declaration of function 'lwline_remove_repeated_points'
lwgeom.c:1190: warning: return makes pointer from integer without a cast
lwgeom.c:1195: warning: implicit declaration of function 'lwcollection_remove_repeated_points'
lwgeom.c:1195: warning: return makes pointer from integer without a cast
lwgeom.c:1198: warning: implicit declaration of function 'lwpoly_remove_repeated_points'
lwgeom.c:1198: warning: return makes pointer from integer without a cast
lwline.c:591: warning: no previous prototype for 'lwline_remove_repeated_points'
lwpoly.c:597: warning: no previous prototype for 'lwpoly_remove_repeated_points'
lwmpoint.c:153: warning: no previous prototype for 'lwmpoint_remove_repeated_points'
lwcollection.c:610: warning: no previous prototype for 'lwcollection_remove_repeated_points'
lwcollection.c: In function 'lwcollection_remove_repeated_points':
lwcollection.c:617: warning: implicit declaration of function 'lwgeom_remove_repeated_points'
lwcollection.c:617: warning: assignment makes pointer from integer without a cast
lex.yy.c:4142: warning: 'yyunput' defined but not used
ar: creating archive liblwgeom.a
Makefile.pgxs:17: warning: overriding commands for target `install'
/usr/local/pgsql/lib/pgxs/src/makefiles/pgxs.mk:96: warning: ignoring old commands for target `install'
Makefile.pgxs:63: warning: overriding commands for target `installdirs'
/usr/local/pgsql/lib/pgxs/src/makefiles/pgxs.mk:143: warning: ignoring old commands for target `installdirs'
Makefile.pgxs:82: warning: overriding commands for target `uninstall'
/usr/local/pgsql/lib/pgxs/src/makefiles/pgxs.mk:163: warning: ignoring old commands for target `uninstall'
lwgeom_functions_basic.c: In function 'ST_RemoveRepeatedPoints':
lwgeom_functions_basic.c:3645: warning: implicit declaration of function 'lwgeom_remove_repeated_points'
lwgeom_functions_basic.c:3645: warning: assignment makes pointer from integer without a cast
lwgeom_geos_clean.c: In function 'LWGEOM_GEOS_makeValidPolygon':
lwgeom_geos_clean.c:538: warning: implicit declaration of function 'GEOSGeom_extractUniquePoints'
lwgeom_geos_clean.c:538: warning: assignment makes pointer from integer without a cast
lwgeom_geos_clean.c:553: warning: initialization makes pointer from integer without a cast
lwgeom_geos_clean.c: At top level:
lwgeom_geos_clean.c:56: warning: 'errorlogger' defined but not used
lwgeom_geos_clean.c:413: warning: 'LWGEOM_GEOS_makeValidPolygon' defined but not used
mac:postgis-svn ol$ 
mac:postgis-svn ol$ gcc --version
i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490)
Copyright (C) 2005 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

mac:postgis-svn ol$ 
mac:postgis-svn ol$ cat ERR
lwgeom.c:1182: warning: no previous prototype for 'lwgeom_remove_repeated_points'
lwgeom.c: In function 'lwgeom_remove_repeated_points':
lwgeom.c:1187: warning: implicit declaration of function 'lwmpoint_remove_repeated_points'
lwgeom.c:1187: warning: return makes pointer from integer without a cast
lwgeom.c:1190: warning: implicit declaration of function 'lwline_remove_repeated_points'
lwgeom.c:1190: warning: return makes pointer from integer without a cast
lwgeom.c:1195: warning: implicit declaration of function 'lwcollection_remove_repeated_points'
lwgeom.c:1195: warning: return makes pointer from integer without a cast
lwgeom.c:1198: warning: implicit declaration of function 'lwpoly_remove_repeated_points'
lwgeom.c:1198: warning: return makes pointer from integer without a cast
lwline.c:591: warning: no previous prototype for 'lwline_remove_repeated_points'
lwpoly.c:597: warning: no previous prototype for 'lwpoly_remove_repeated_points'
lwmpoint.c:153: warning: no previous prototype for 'lwmpoint_remove_repeated_points'
lwcollection.c:610: warning: no previous prototype for 'lwcollection_remove_repeated_points'
lwcollection.c: In function 'lwcollection_remove_repeated_points':
lwcollection.c:617: warning: implicit declaration of function 'lwgeom_remove_repeated_points'
lwcollection.c:617: warning: assignment makes pointer from integer without a cast
lex.yy.c:4142: warning: 'yyunput' defined but not used
ar: creating archive liblwgeom.a
Makefile.pgxs:17: warning: overriding commands for target `install'
/usr/local/pgsql/lib/pgxs/src/makefiles/pgxs.mk:96: warning: ignoring old commands for target `install'
Makefile.pgxs:63: warning: overriding commands for target `installdirs'
/usr/local/pgsql/lib/pgxs/src/makefiles/pgxs.mk:143: warning: ignoring old commands for target `installdirs'
Makefile.pgxs:82: warning: overriding commands for target `uninstall'
/usr/local/pgsql/lib/pgxs/src/makefiles/pgxs.mk:163: warning: ignoring old commands for target `uninstall'
lwgeom_functions_basic.c: In function 'ST_RemoveRepeatedPoints':
lwgeom_functions_basic.c:3645: warning: implicit declaration of function 'lwgeom_remove_repeated_points'
lwgeom_functions_basic.c:3645: warning: assignment makes pointer from integer without a cast
lwgeom_geos_clean.c: In function 'LWGEOM_GEOS_makeValidPolygon':
lwgeom_geos_clean.c:538: warning: implicit declaration of function 'GEOSGeom_extractUniquePoints'
lwgeom_geos_clean.c:538: warning: assignment makes pointer from integer without a cast
lwgeom_geos_clean.c:553: warning: initialization makes pointer from integer without a cast
lwgeom_geos_clean.c: At top level:
lwgeom_geos_clean.c:56: warning: 'errorlogger' defined but not used
lwgeom_geos_clean.c:413: warning: 'LWGEOM_GEOS_makeValidPolygon' defined but not used

[strk]

Please try r5298.

[strk]

Oops, r5299 please.

[colivier]

Yeap Sandro, fine for me

Current warnings are mine now :/