Opened 5 years ago

Closed 5 years ago

#4318 closed defect (fixed)

Stop passing libraries manually

Reported by: Algunenano Owned by: Algunenano
Priority: medium Milestone: PostGIS 3.0.0
Component: postgis Version: master
Keywords: Cc:

Description

postgis/Makefile.in and topology/Makefile.in are manually setting -fPIC in the CFLAGS. Instead they should be using @PICFLAGS@ which is populated during ./configure.

For example, in my system PICFLAGS is set to -fPIC -DPIC (which doesn't have any impact in Postgis) but in other platforms the flags can be different.

I also wonder if it's still needed if we keep the behaviour of building everything statically.

Change History (2)

comment:1 by Algunenano, 5 years ago

Owner: changed from pramsey to Algunenano
Summary: Stop passing `-fPIC` manually → Stop passing libraries manually

In different points of the build system we are passing fPIC -lgeos-c or lproj. This should be handled only using the flags producing in the configure step.

comment:2 by Raul Marin, 5 years ago

Resolution: → fixed
Status: new → closed

In 17246:

Only use configure variables to pass ldflags

Closes #4318

Note: See TracTickets for help on using tickets.