Opened 5 years ago

Closed 5 years ago

#4288 closed defect (fixed)

Changes to liblwgeom/lwinline.h don't trigger a rebuild

Reported by: Algunenano Owned by: Algunenano
Priority: medium Milestone: PostGIS 3.0.0
Component: build Version: master
Keywords: Cc:

Description

If you modify anything in liblwgeom/lwinline.h and rebuild the project nothing will be recompiled.

I guess the solution is to add it to SA_HEADERS

Change History (3)

comment:1 by komzpa, 5 years ago

There is completely alternative way of solving this: compile all the liblwgeom as single compiler call, without building a bunch of .o files and then linking them. May require a rework of build system but is potentially a bigger gain.

comment:2 by Algunenano, 5 years ago

There is completely alternative way of solving this: compile all the liblwgeom as single compiler call, without building a bunch of .o files and then linking them. May require a rework of build system but is potentially a bigger gain.

That would mean that changing a single character in a .c would force rebuilding everything and that things like ccache become useless. I'm not a fan unless you show some super big win elsewhere, and even if you did, I'd ask for an option to only enable it during release.

comment:3 by Raul Marin, 5 years ago

Resolution: fixed
Status: assignedclosed

In 17147:

Force liblwgeom recompilation when lwinline.h changes

Closes https://github.com/postgis/postgis/pull/359
Closes #4288

Note: See TracTickets for help on using tickets.