#4213 closed enhancement (fixed)

Use TupleDescAttr to access tupdesc attributes

Reported by: Algunenano Owned by: Algunenano
Priority: medium Milestone: PostGIS 3.0.0
Component: postgis Version: trunk
Keywords: Cc:

Description

Comes from https://github.com/CartoDB/odbc_fdw/commit/244fae80ae6f9aefb5681ddaab99e5181595c21d#r30945886

This really should use TupleDescAttr(), not hardcode the access. It's been backpatched (with the appriiate definition), too. If you want to support older minor versions, just define it yourself.

Defined in tupdesc.h

#define TupleDescAttr(tupdesc, i) (&(tupdesc)->attrs[(i)])

Direct access is being used currently in, at least, these places: postgis/geobuf.c (61, 131) postgis/mvt.c (338)

Change History (1)

comment:1 Changed 11 months ago by Algunenano

Resolution: fixed
Status: assignedclosed

Done in r16958

Note: See TracTickets for help on using tickets.