Opened 6 years ago

Closed 6 years ago

#4193 closed task (fixed)

Create rt_legacy.c, postgis_legacy.c

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 3.0.0
Component: postgis Version: master
Keywords: Cc:

Description (last modified by robe)

I plan to create two c function files to store legacy functions and each function will just throw an error when called instructing the user to upgrade their install.

This was Darafei's idea and I think a good one even if we don't go into the "Oh my god we are changing so much" that gave pramsey the heebeegeebees in this pull request

https://github.com/postgis/postgis/pull/302

For starters I will put the pg_abs and the RT_AsBinary thingy functions in herethat were taken out in 2.5.

These I had already changed in 2.5 to stub with errors so symlink still works.

That will allow coming from 2.2 → 3.0 by symlinking when you do a pg_upgrade.

Next I will find the function we took out in 2.2 (I forget the name) that broke pg_upgrading between 2.1 and 2.2

I think we might have some breakers between 2.0 and 2.1 as well which I'll try to dig up.

I'm hoping all those folks stuck in 2.0 and 2.1 because their database is too big not to do a dump restore can be encouraged to move up to 3.0 if pg_upgrade from 2.0 → 3.0 is relatively painless

Change History (4)

comment:1 by robe, 6 years ago

Description: modified (diff)

comment:2 by robe, 6 years ago

In 17072:

Create rt_legacy.c and postgis_legacy.c put back functions taken out in 2.5 and put them in these files. Stub them with errors.
Still need to check 2.1 - 2.4 for things we might have taken out (only test pg_upgrade from 9.4 2.4 to 11 3.0 which failed with 3.0 needs dump restore)
References #4193 for PostGIS 3.0 (trunk)

comment:3 by robe, 6 years ago

In 17073:

Remove functions moved to postgis_legacy.c
References #4193 for PostGIS 3.0 (trunk)

comment:4 by komzpa, 6 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.