legacy regress test is broken

[robe]

Make install is broken. Seeing this on all the bots

Seems to be an issue since I flipped the switch, which is odd, cause I didn't even change to dropping the minor

 legacy .. failed (diff expected obtained: /projects/postgis/tmp/3.0.0dev_pg10_geos3.7.0dev_gdal2.2.4w64/test_50_diff)
-----------------------------------------------------------------------------
--- legacy_expected	2017-10-26 19:18:11.560448900 -0400
+++ /projects/postgis/tmp/3.0.0dev_pg10_geos3.7.0dev_gdal2.2.4w64/test_50_out	2018-08-29 12:42:35.641212200 -0400
@@ -1,21 +1,9691 @@
+\cd: could not change directory to "E:/jenkins/postgresql/rel/pg10w64gcc48/share/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "E:/jenkins/postgresql/rel/pg10w64gcc48/share/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "E:/jenkins/postgresql/rel/pg10w64gcc48/share/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "E:/jenkins/postgresql/rel/pg10w64gcc48/share/contrib/postgis-3.": No such file or directory

So perhaps something else in our code is causing it

[robe]

shows a little differently on bessie but still failing at the legacy bit

06:05:33  legacy ..FATAL: command execution failed
06:57:22 java.io.EOFException
06:57:22 	at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2681)
06:57:22 	at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3156)
06:57:22 	at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:862)
06:57:22 	at java.io.ObjectInputStream.<init>(ObjectInputStream.java:358)
06:57:22 	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:48)
06:57:22 	at hudson.remoting.Command.readFrom(Command.java:140)
06:57:22 	at hudson.remoting.Command.readFrom(Command.java:126)
06:57:22 	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTranspo

Debbie showing failure on legacy, so perhaps it's just the regex in legacy is screwed

legacy .. failed (diff expected obtained: /var/lib/jenkins/workspace/postgis/tmp/3_0_pg10w64/test_50_diff)
-----------------------------------------------------------------------------
--- legacy_expected	2018-08-19 22:53:18.856431279 +0000
+++ /var/lib/jenkins/workspace/postgis/tmp/3_0_pg10w64/test_50_out	2018-08-28 07:17:03.594381508 +0000
@@ -1,21 +1,5446 @@
-Starting up MapServer/Geoserver tests...
-Setting up the data table...
-public.wmstest.pt SRID:4326 TYPE:POLYGON DIMS:2 
-Running Geoserver 2.0 NG tests...
-Geoserver1|POLYGON
-Geoserver2|4326
-Geoserver3|-500|AAAAAAMAAAABAAA
-Geoserver4|1
-Geoserver5|25|AAAAAAMAAAABAAA
-Geoserver6|25|AAAAAAMAAAABAAA
-MapServer1|id
-MapServer2|-9465|AQcAAAABAAAAAQM|-9465
-MapServer2|-9460|AQcAAAABAAAAAQM|-9460
-MapServer3|id
-MapServer4|-9465|010700000001000|-9465
-MapServer4|-9460|010700000001000|-9460
-Removing the data table...
-Done.
-1869|POINT(1 2)
-BEGIN
-COMMIT
+\cd: could not change directory to "/var/lib/jenkins/workspace/pg/rel/pg10w64/share/postgresql/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "/var/lib/jenkins/workspace/pg/rel/pg10w64/share/postgresql/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "/var/lib/jenkins/workspace/pg/rel/pg10w64/share/postgresql/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "/var/lib/jenkins/workspace/pg/rel/pg10w64/share/postgresql/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "/var/lib/jenkins/workspace/pg/rel/pg10w64/share/postgresql/contrib/postgis-3.": No such file or directory

[robe]

In 16712:

Revise compute of $scriptdir so allows minors with 0.
Closes #4166

[robe]

Still failing on legacy regress for winnie

legacy .. failed (diff expected obtained: /projects/postgis/tmp/3.0.0dev_pg10_geos3.7.0dev_gdal2.2.4w64/test_50_diff)
-----------------------------------------------------------------------------
--- legacy_expected	2017-10-26 19:18:11.560448900 -0400
+++ /projects/postgis/tmp/3.0.0dev_pg10_geos3.7.0dev_gdal2.2.4w64/test_50_out	2018-09-02 20:34:23.415531500 -0400
@@ -1,21 +1,9691 @@
+\cd: could not change directory to "E:/jenkins/postgresql/rel/pg10w64gcc48/share/contrib/postgis-3.": No such file or directory
+psql:legacy.sql:11: \cd: could not change directory to "E:/jenkins/postgresql/rel/pg10w64gcc48/share/contrib/postgis-3.": No such file or directory

Though not failing on debbie, anymore but she's not happy with raster. Will post a separate ticket for that.

[robe]

I think I resolve this already.