ST_GeomFromTWKB throws an error when reading bbox around 3D geometry

[atallah]

Here is one particular breaking example

select st_AsTWKB(st_GeometryFromText('POINT Z(1 2 3)'), 0, 0, 0, false, true);
// \x010901020004000600020406
select st_astext(st_geomfromtwkb('\x010901020004000600020406'));
// ERROR:  varint_u64_decode: varint extends past end of buffer

While I of course couldn't check all possible configurations that lead to this, I found that this happens for POINT Z, LINESTRING Z and POLYGON Z, but only when includeBbox is set to true. Precision did not seem to make a difference.

[nicklas]

I can replicate

I have also studied the output of ST_AsTWKB which looks ok. So ST_GeomFromTWKB is main suspect.

I will take a look on ST_GeomFromTWKB, should be fairly easy to track down.

[nicklas]

Fixed in :

trunk r16572

2.4 r16573

2.3 r16574

2.2 r16575

Thank you atallah! Good catch