Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4035 closed enhancement (fixed)

remove pgis_abs dummy type

Reported by: pramsey Owned by: pramsey
Priority: medium Milestone: PostGIS 2.5.0
Component: postgis Version: master
Keywords: Cc:

Description

Since we no longer require a dummy type in order to drive the aggregation machinery, remove the pgis_abs type and replace with the 'internal' type.

Change History (6)

comment:1 by pramsey, 6 years ago

Resolution: fixed
Status: assignedclosed

In 16443:

Remove the pgis_abs dummy type and replace with use of 'internal' type.
Closes #4035

comment:2 by dbaston, 6 years ago

Does Postgres care about the size of an internal state type? I recall that we had to adjust pg_type when increasing the size of pgis_abs in the past.

comment:3 by pramsey, 6 years ago

Summary: remote pgis_abs dummy typeremove pgis_abs dummy type

comment:4 by pramsey, 6 years ago

I don't know the answer to that, dbaston. I kept the pgis_abs struct, and the 'internal' type seems to just pass a pointer, so once the data which used to be in the pgis_abs type and was passed by value was correctly placed in the aggregate memory context everything worked again like magic.

comment:5 by pramsey, 6 years ago

In 16446:

Annotate changed function signatures for pgis_abs removal
References #4035

comment:6 by pramsey, 6 years ago

In 16447:

Drop unused functions for pgis_abs during upgrades
References #4035

Note: See TracTickets for help on using tickets.