Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3992 closed defect (fixed)

Use PKG_PROG_PKG_CONFIG macro from pkg.m4 to detect pkg-config.

Reported by: Bas Couwenberg Owned by: strk
Priority: medium Milestone: PostGIS 2.4.4
Component: build Version: 2.4.x
Keywords: Cc: Bas Couwenberg

Description

The AC_PATH_PROG macro fails to select the correct version to support cross-compilation.

This triggers a lintian issue for the Debian package builds: autotools-pkg-config-macro-not-cross-compilation-safe

The package appears to use AC_PATH_PROG to discover the location of pkg-config(1). This macro fails to select the correct version to support cross-compilation.

A better way would be to use the PKG_PROG_PKG_CONFIG macro from pkg.m4 and then using the $PKG_CONFIG shell variable.

Refer to https://bugs.debian.org/884798 for details.

The attached patch implements this suggestion.

Attachments (1)

autotools-pkg-config-macro-not-cross-compilation-safe.patch (11.4 KB ) - added by Bas Couwenberg 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by strk, 6 years ago

Resolution: fixed
Status: newclosed

In 16324:

Use PKG_PROG_PKG_CONFIG macro from pkg.m4 to detect pkg-config

Patch by Bas Couwenberg
Closes #3992

comment:2 by strk, 6 years ago

Milestone: PostGIS 2.4.3PostGIS 2.4.4

comment:3 by strk, 6 years ago

In 16325:

Use PKG_PROG_PKG_CONFIG macro from pkg.m4 to detect pkg-config

Patch by Bas Couwenberg
Closes #3992 in 2.4 branch (for 2.4.4)

comment:4 by strk, 6 years ago

In 16335:

Forgot to add pkg.m4 macro in r16324

See #3992

comment:5 by strk, 6 years ago

In 16336:

Forgot to add pkg.m4 macro in r16324

See #3992

Note: See TracTickets for help on using tickets.