Opened 4 years ago

Closed 4 years ago

#3988 closed defect (fixed)

with_interrupt_tests using non-standard extension

Reported by: robe Owned by: strk
Priority: blocker Milestone: PostGIS 2.4.3
Component: build/upgrade/install Version: 2.4.x
Keywords: Cc:

Description

As noted by Greg Troxel

Thanks for making the rc; it's not only easier for me to test with but it also exercises the entire release/packaging path.

A minor issue: there is a new bashism of == in test (POSIX does not allow this).  (It would be cool if buildbots ran tests with a shell that does not accept non-standard extensions :-).

  ERROR: [check-portability.awk] => Found test ... == ...:
  ERROR: [check-portability.awk] configure: if test
  "x$with_interrupt_tests" == "xno"; then

This needs to be fixed in configure.ac.

After fixing that, my build succeeded:

 NetBSD 7_STABLE  amd64
 PostgreSQL 9.5.10 on x86_64--netbsd, compiled by gcc (nb2 20150115)  4.8.5, 64-bit  Postgis 2.4.3rc1 - r16289 - 2018-01-14 16:34:36  scripts 2.4.3rc1 r16289  raster scripts 2.4.3rc1 r16289
 GEOS: 3.5.1-CAPI-1.9.1 r4246
 PROJ: Rel. 4.9.3, 15 August 2016
 GDAL: GDAL 2.0.3, released 2016/07/01

I had the expected changes in the set of installed files (scripts with versions).

Tests all passed.

So other than fixing the ==, looks great from here.

https://lists.osgeo.org/pipermail/postgis-devel/2018-January/026821.html

Attachments (1)

test-double-equals.patch (388 bytes) - added by gdt 4 years ago.
patch to fix use of == with test

Download all attachments as: .zip

Change History (4)

comment:1 Changed 4 years ago by robe

Component: postgisbuild/upgrade/install
Owner: changed from pramsey to strk

Changed 4 years ago by gdt

Attachment: test-double-equals.patch added

patch to fix use of == with test

comment:2 Changed 4 years ago by robe

In 16297:

with_interrupt_tests using non-standard extension
Patch from Greg Troxel
References #3988 for PostGIS 2.5 (trunk)

comment:3 Changed 4 years ago by robe

Resolution: fixed
Status: newclosed

In 16298:

with_interrupt_tests using non-standard extension
Closes #3988 for PostGIS 2.4.3

Note: See TracTickets for help on using tickets.