Opened 7 years ago

Closed 7 years ago

#3912 closed defect (fixed)

glibtoolize doesn't install install-sh

Reported by: pramsey Owned by: strk
Priority: blocker Milestone: PostGIS 2.2.7
Component: postgis Version: 2.4.x
Keywords: Cc:

Description

When bundling using make_dist.sh from within the respository directory, glibtoolize will fail to include install-sh because it sees that a copy already exists one level above it in ...

Change History (20)

comment:1 by pramsey, 7 years ago

Sandro reports that

Seems to be fixed by adding this to configure.ac:

    AC_CONFIG_AUX_DIR(.)

comment:2 by strk, 7 years ago

In 16025:

More INSTALL fixes

See #3912

comment:3 by strk, 7 years ago

The HOWTO_RELEASE file seems to prescribe testing the build after tarball is made:

- Run: sh make_dist.sh $rev (or use debbie for this)
- Build and test generated tarball (including extension upgrade)

Should it be more explicit in recommending _not_ to run ./autogen.sh ?

comment:4 by strk, 7 years ago

All bots are happy, will backport to all supported branches.

comment:5 by strk, 7 years ago

In 16029:

Put build AUX files under build-aux

Cleans and ignore build aux files from new location,
and remove spurious install-sh from repository.

References #3912 for 2.4 branch

comment:6 by strk, 7 years ago

In 16030:

Put build AUX files under build-aux

Cleans and ignore build aux files from new location,
and remove spurious install-sh from repository.

References #3912 for 2.3 branch

comment:7 by strk, 7 years ago

Resolution: fixed
Status: assignedclosed

In 16031:

Put build AUX files under build-aux

Cleans and ignore build aux files from new location,
and remove spurious install-sh from repository.

Closes #3912 in 2.2 branch

comment:8 by robe, 7 years ago

Resolution: fixed
Status: closedreopened

As noted in #3916 this change broke my ability to

make install.

For some reason @INSTALL@ is resolving to ../ instead of ../install-sh

Manually editing generated make files to add in install-sh works.

Also you have the milestone flagged wrong on this sinc eyou push it to 2.2 and I'd also like to yell and scream that you did not note this change in the NEWS files.

comment:9 by robe, 7 years ago

Priority: mediumblocker

comment:10 by robe, 7 years ago

Milestone: PostGIS 2.4.2PostGIS 2.2.7

comment:11 by strk, 7 years ago

Make sure there's no "install-sh" in your path when running ./autogen.sh, try moving source tree around. Also see if adding AC_PROG_INSTALL to configure.ac helps.

comment:12 by robe, 7 years ago

In 16067:

Make install no longer works under mingw64
Add a AC_PROG_INSTALL step to configure.ac to fix.
References #3916
References #3912

comment:13 by robe, 7 years ago

In 16068:

add comment
References #3916
References #3912

comment:14 by robe, 7 years ago

In 16072:

Revert change of AC_PROG_INSTALL step to configure.ac.
Succeeeded in only replacing install-sh with install, which can't create directories under mingw
References #3916
References #3912

comment:15 by robe, 7 years ago

In 16073:

Hard-code build-aux/install-sh in all install scripts
instead of relying on @INSTALL@ to pick an install executable
on systems where @INSTALL@ resolves, ends up picking the system preferred install
which at least on mingw64 won't directories if they don't exist
in addition on mingw64, it doesn't
even fill in @INSTALL@ with install unless AC_PROG_INSALL is included
References #3916 for PostGIS 2.5 (trunk)
References #3912 for PostGIS 2.5 (trunk)

comment:16 by strk, 7 years ago

In 16080:

Make sure target directories are created before copying files to them

References #3912
References #3916

comment:17 by robe, 7 years ago

In 16083:

change back to using @INSTALL@ and put in AC_PROG_INSTALL
so install doesn't go to ../ for insall on mingw
References #3916
References #3912

comment:18 by strk, 7 years ago

In 16086:

Make sure target directories are created before copying files to them

References #3912 for 2.4 branch
References #3916 for 2.4 branch

comment:19 by strk, 7 years ago

In 16087:

Make sure target directories are created before copying files to them

References #3912 for 2.3 branch
References #3916 for 2.3 branch

comment:20 by strk, 7 years ago

Resolution: fixed
Status: reopenedclosed

In 16088:

Make sure target directories are created before copying files to them

Closes #3912 in 2.2 branch
Closes #3916 in 2.2 branch

Note: See TracTickets for help on using tickets.