Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3898 closed defect (fixed)

ANY-2.5.0dev is showing as an upgrade option

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.5.0
Component: build Version: master
Keywords: Cc:

Description (last modified by robe)

I just noticed something which I think is unintentional.

When I go to upgrade postgis via pgAdmin 4 gui (same with pgAdmin3), I now have an ANY-2.5.0dev option.

It's harmless but kinda confusing to a user.

If I try to upgrade to ANY, I get

ERROR: extension "postgis" has no update path from version "2.5.0dev" to version "ANY-2.5.0dev"

Attachments (2)

upgrade_any.png (17.9 KB ) - added by robe 7 years ago.
upgrade_no_next.png (17.6 KB ) - added by robe 7 years ago.

Download all attachments as: .zip

Change History (11)

by robe, 7 years ago

Attachment: upgrade_any.png added

comment:1 by robe, 7 years ago

Description: modified (diff)

comment:2 by strk, 7 years ago

Resolution: fixed
Status: newclosed

In 15974:

Add missing dash in ANY— upgrade path

Fixes #3898

comment:3 by strk, 7 years ago

Unintentional, looks like I forgot a dash. You'll have to clean that up manually or "make uninstall" before updating codebase to r15974 in order to test the fix.

by robe, 7 years ago

Attachment: upgrade_no_next.png added

comment:4 by robe, 7 years ago

After I purged all my 2.5.0 install files, compiled, reinstalled

make check RUNTESTFLAGS=--extension
ERROR:  extension "postgis" has no update path from version "2.5.0dev" to version "2.5.0devnext"

Indeed the ANY option is gone, but I have no next option

comment:5 by strk, 7 years ago

Regina it should be installed by make install which should call make install-upgrade-paths which would call this:

install-upgrade-paths: sql_bits/postgis_extension_upgrade_minor.sql
  tpl='$(EXTENSION)--ANY--$(EXTVERSION).sql'; \
  ln -fs "$${tpl}" $(EXTDIR)/$(EXTENSION)--$(EXTVERSION)--$(EXTVERSION)next.sql; \
  ln -fs "$${tpl}" $(EXTDIR)/$(EXTENSION)--$(EXTVERSION)next--$(EXTVERSION).sql; \
  $(INSTALL_DATA) $^ "$(EXTDIR)/$${tpl}"; \
  for OLD_VERSION in $(UPGRADEABLE_VERSIONS); do \
    ln -fs "$${tpl}" $(EXTDIR)/$(EXTENSION)--$$OLD_VERSION--$(EXTVERSION).sql; \
  done

See the "next" part is installing a symlink to ${tpl} which should be the ANY file.

comment:6 by robe, 7 years ago

Well it's working now not sure why it didn't work on first make install.

comment:7 by robe, 7 years ago

But wait. It's not working on winnie

and been failing for quite sometime. Longer than I keep logs for.

https://debbie.postgis.net:444/job/PostGIS_EDB_Regress_winnie/5936/consoleFull

Upgrading PostGIS in 'postgis_reg' using: ALTER EXTENSION postgis UPDATE TO '2.5.0devnext'
Died at run_test.pl line 1423.
 failed (Error encountered altering EXTENSION POSTGIS: /projects/postgis/tmp/2.5.0dev_pg10_geos3.7.0dev_gdal2.2.2w32/regress_log)
-----------------------------------------------------------------------------
sh: createlang: command not found
CREATE EXTENSION
CREATE EXTENSION
ERROR:  extension "postgis" has no update path from version "2.5.0dev" to version "2.5.0devnext"
-----------------------------------------------------------------------------
make[1]: *** [Makefile:303: check] Error 1
make[1]: Leaving directory '/projects/postgis/branches/2.5/regress'
make: *** [GNUmakefile:16: check] Error 1

I'll ticket as separate issue might be the way I install on winnie, cause files get installed on the mingw but I copy over to the VC++ build. Though locally I'm testing vc++ build.

comment:8 by strk, 7 years ago

What I see on last winnie buildi is this:

Test: test_kmeans ...Makefile:86: recipe for target 'check' failed
make[2]: *** [check] Segmentation fault

REF: https://debbie.postgis.net:444/view/PostGIS/job/PostGIS_EDB_Regress_winnie/5943/console

Where are you seing the missing update path ?

comment:9 by robe, 7 years ago

that's the random kmeans segfault that happens once in a while nothing new there. I updated the build / regress scripts before that. Anyway new info about this will go on #3901.

Note: See TracTickets for help on using tickets.