protobuf warning

[robe]

Should we be concerned about these?

-DHAVE_SFCGAL    -fPIC -I/usr/include -DHAVE_SFCGAL -I. -I./ -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/server -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/internal  -D_GNU_SOURCE   -c -o postgis_libprotobuf.o postgis_libprotobuf.c
/usr/bin/protoc-c --c_out=. vector_tile.proto
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: vector_tile.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
gcc -I../liblwgeom  -fPIC -I../libpgcommon  -I/var/lib/jenkins/workspace/geos/rel-3.7.0devw64/include   -I/usr/include/libxml2 -I/usr/include -DHAVE_SFCGAL    -fPIC -I/usr/include -DHAVE_SFCGAL -I. -I./ -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/server -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/internal  -D_GNU_SOURCE   -c -o vector_tile.pb-c.o vector_tile.pb-c.c
/usr/bin/protoc-c --c_out=. geobuf.proto
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: geobuf.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
gcc -I../liblwgeom  -fPIC -I../libpgcommon  -I/var/lib/jenkins/workspace/geos/rel-3.7.0devw64/include   -I/usr/include/libxml2 -I/usr/include -DHAVE_SFCGAL    -fPIC -I/usr/include -DHAVE_SFCGAL -I. -I./ -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/server -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/internal  -D_GNU_SOURCE   -c -o geobuf.pb-c.o geobuf.pb-c.c
/usr/bin/protoc-c --c_out=. vector_tile.proto
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: vector_tile.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
gcc -I../liblwgeom  -fPIC -I../libpgcommon  -I/var/lib/jenkins/workspace/geos/rel-3.7.0devw64/include   -I/usr/include/libxml2 -I/usr/include -DHAVE_SFCGAL    -fPIC -I/usr/include -DHAVE_SFCGAL -I. -I./ -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/server -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/internal  -D_GNU_SOURCE   -c -o mvt.o mvt.c
gcc -I../liblwgeom  -fPIC -I../libpgcommon  -I/var/lib/jenkins/workspace/geos/rel-3.7.0devw64/include   -I/usr/include/libxml2 -I/usr/include -DHAVE_SFCGAL    -fPIC -I/usr/include -DHAVE_SFCGAL -I. -I./ -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/server -I/var/lib/jenkins/workspace/pg/rel/pg11.0w64/include/postgresql/internal  -D_GNU_SOURCE   -c -o lwgeom_out_mvt.o lwgeom_out_mvt.c
/usr/bin/protoc-c --c_out=. geobuf.proto
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: geobuf.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)

[robe]

I suppose this is harmless since it defaults to proto2. Are we using proto2?

[Björn Harrtell]

Yeah this is harmless and also an upstream warning. proto files come from upstream and they are implicitly proto2, but at some point it became a warning to not spec it explicitly.

[strk]

Where is the upstream ?

[Björn Harrtell]

​https://github.com/mapbox/vector-tile-spec/blob/master/2.1/vector_tile.proto

[strk]

I've asked upstream about how to fix the warning: ​https://github.com/mapbox/vector-tile-spec/issues/90#issuecomment-496959202

[strk]

Can people with very old protoc versions try ​https://git.osgeo.org/gitea/postgis/postgis/pulls/32 ?