Opened 7 years ago

Closed 7 years ago

#3812 closed defect (fixed)

Changed 2" isn't numeric

Reported by: strk Owned by: pramsey
Priority: medium Milestone: PostGIS 2.4.0
Component: postgis Version: 2.3.x
Keywords: Cc:

Description

I've noticed a couple of warnings upon generating postgis_upgrade.pl:

Argument "2\n-- Changed 2" isn't numeric in addition (+) at ../utils/postgis_proc_upgrade.pl line 105, <INPUT> line 3883.
Argument "2\n-- Changed 2" isn't numeric in addition (+) at ../utils/postgis_proc_upgrade.pl line 105, <INPUT> line 3892.

These are due to a regexp assuming that above SQL objects you only find comments with a given version pattern:

.*(?:Availability|Changed|Updated):\s([^\.])\.([^.]*)

That is, Availability or Changed or Updated followed by a colon.

Two comments broke the assumption:

-- Availability: 2.2
-- Changed 2.4.0: marked parallel safe

And:

-- Availability: 2.2
-- Changed 2.4.0: marked parallel safe

In other places the format was correct, like here:

-- Availability: 1.2.2
-- Changed: 2.4.0 marked parallel safe
CREATE AGGREGATE ST_Accum (geometry) (

The upgrade script will generate DROP and CREATE based on that information, so these errors should result in non-parallel safe aggregates on upgrade. It's a blocker.

Change History (2)

comment:1 by strk, 7 years ago

Making the script nicer so to give a clearer error message might be also a useful thing to do

comment:2 by robe, 7 years ago

Resolution: fixed
Status: newclosed

In 15578:

Revise comment format of some aggregates so that postgis upgrade script generator picks them up
Closes #3812

Note: See TracTickets for help on using tickets.