Opened 8 years ago

Closed 8 years ago

#3621 closed defect (fixed)

ST_MakeLine supports MULITPOINT in 2.3.0 but not 2.2.2

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 2.3.0
Component: documentation Version: master
Keywords: Cc:

Description

This might be a documentation bug, or a regression change in PostGIS 2.2.2.

I was shocked to find this discrepancy in garden tests

SELECT ST_AsText(ST_MakeLine('MULTIPOINT(-10 40,-10 55,-10 70,5 40,5 55,5 70,20 40,20 55,20 70,35 40,35 55,35 70,50 40,50 55,50 70)'::geometry));

In PostGIS 2.3.0 dev r15053 Returns

LINESTRING(-10 40,-10 55,-10 70,5 40,5 55,5 70,20 40,20 55,20 70,35 40,35 55,35 70,50 40,50 55,50 70)

But in PostGIS 2.2.2 returns

NULL

But according to our docs, we've supported MULTIPOINT as input in ST_MakeLine since PostGIS 2.0, which would suggest if that is true 2.2.2 ST_MakeLine was broken (or we really didn't support this until now)

Change History (4)

comment:1 by dbaston, 8 years ago

Paul Norman added this during the Paris sprint, see #3469

comment:2 by robe, 8 years ago

Okay so I'll correct the docs. I recall him mentioning it, but he kept on pointing at the docs saying — see we've had multipoint since 2.0 (which came as a shock to me), so I thought he was implementing support for having ST_MakeLine support linestrings not multipoints.

comment:3 by robe, 8 years ago

Component: postgisdocumentation
Owner: changed from pramsey to robe

Ah okay I see now what's happening looking at that ticket. First it was LINESTING we always had not MULTIPOINT (so my memory is just failing there of what Paul said). Secondly Paul had a typo in his commit. He copied the old comment (but neglected to change the 2.0.0. to 2.3.0). I'm on it now. Thanks Dan for clarifying that.

comment:4 by robe, 8 years ago

Resolution: fixed
Status: newclosed

In 15058:

Multipoint support for ST_MakeLine was introduced in 2.3, not 2.0. Reshuffle availability so last is first.
Closes #3621

Note: See TracTickets for help on using tickets.