Opened 3 years ago

Closed 19 months ago

#3601 closed defect (worksforme)

Translation Backrolled

Reported by: ruvyn Owned by: robe
Priority: high Milestone: PostGIS 2.4.0
Component: documentation Version: trunk
Keywords: PostGIS 2.3.0dev Manual Cc: jangbi882, ruvyn

Description

While translating PostGIS 2.3.0dev Manual in Transifex, I noticed that 'old' translation texts from, like, 3 years ago are reapplied over my 'new' translation.

Might be the error of Manual Webpage auto-update Makefile? Does not check if there are new changes, just push any xml.pot file to server? Maybe, maybe not, 'cause I still don't understand how the 'old' files from server can be backrolled in Transifex.

Please make sure that this does not happen again.

Change History (12)

comment:1 Changed 3 years ago by strk

Did it happen to _all_ translations or just a specific language ?

comment:2 Changed 3 years ago by strk

If I "make pull-tx" right now I see many changes to the ko_KR translation, and not any other. Reviewing the changes I see that the revision date of the old one was 2015-09-29, and author was myself. The new one has date 2016-07-20 and you are the author. There is no trace in the repository showing _who_ pushed the 2015-09-29 translations to Transifex, does Transifex known ?

I've committed the changes with r15023. Should we try contenting a smaller change, for test purpose ?

comment:3 in reply to:  2 Changed 3 years ago by ruvyn

Replying to strk:

There is no trace in the repository showing _who_ pushed the 2015-09-29 translations to Transifex, does Transifex known ?

In Transifex, on History tab, you can see "by strk, 19 days ago". That was Mon, Jul 4 2016 2:29PM. See https://www.transifex.com/postgis/postgis/translate/#ko_KR/postgisxmlpot/19188018

I've committed the changes with r15023. Should we try contenting a smaller change, for test purpose ?

Yes, I think you can test on postgis.xml.pot file, link above, cause it is the smallest - just 6 strings - file. I have a question though. I can see you committed my translation files to the server, but the translation texts are not applied on Korean Manual Webpage http://postgis.net/docs/manual-dev/postgis-ko_KR.html, could you please check out why?

comment:4 Changed 3 years ago by strk

#3574 is the ticket for the non-updated manual

Maybe #2967 is also related.

comment:5 Changed 3 years ago by strk

Someone submitted updates to the Korean translation in the form of a github pull request: https://github.com/postgis/postgis/pull/109

I'm not in a position to check which one is new between transifex and the pr code. Ruvyn, can you take care of that ?

comment:6 in reply to:  5 Changed 3 years ago by ruvyn

Replying to strk:

Someone submitted updates to the Korean translation in the form of a github pull request: https://github.com/postgis/postgis/pull/109

I'm not in a position to check which one is new between transifex and the pr code. Ruvyn, can you take care of that ?

Yes, I'm working with jangbi882 for Korean translation. This morning he informed me that he downloaded the latest translation files and committed the 'pull request', because for whatever reason, the usual auto-update method for Korean Manual Webpage is not working. I hope you could confirm this pull request of Korean translation so we could see what would happen.

comment:7 Changed 3 years ago by strk

The http://postgis.net/docs/manual-dev/postgis-ko_KR.html page is generated and published by one of the Jenkins installs (Debbie or Winnie). I remember at one point the generation process had failures (in particular for generating the PDF) so Regina might have removed the generation step.

Regina: can you tell us more about it ?

Ruvyn: can you generate those pages yourself ?

make -C doc/po/ko_KR local-html
make -C doc/po/ko_KR local-pdf

The html one fails for me with:

po2xml ../../reference_raster.xml reference_raster.xml.po > reference_raster.xml
the translation of '<refpurpose>Returns a raster or a set of geometry-pixelvalue pairs representing the shared portion of two rasters or the geometrical intersection of a vectorization of the raster and a geometry.</refpurpose>' doesn't start with a tag.

Revealing there's a bug in the translation text.

It's probably best to continue the discussion about stopped auto-update on #3574 and keep this ticket for the problem of accidental override of transifex translations from local changes (chances are the problem was fixed locally and pushed to transifex but now overridden again)

comment:8 in reply to:  7 Changed 3 years ago by ruvyn

Replying to strk:

The html one fails for me with:

po2xml ../../reference_raster.xml reference_raster.xml.po > reference_raster.xml
the translation of '<refpurpose>Returns a raster or a set of geometry-pixelvalue pairs representing the shared portion of two rasters or the geometrical intersection of a vectorization of the raster and a geometry.</refpurpose>' doesn't start with a tag.

Revealing there's a bug in the translation text.

Sorry, Sandro. I added the missing tags just now. Hope there is no more error like that. And for the other question, no, I do not have the authority to generate HTML pages or PDF files. For this, BJ Jang(jangbi882) of Gaia3D, inc. will answer.

comment:9 Changed 3 years ago by strk

Answers are in #3574, which is the ticket related to HTML generation problems. Please let this ticket handle backrolled translation issue.

comment:10 Changed 2 years ago by robe

Milestone: PostGIS 2.3.0PostGIS 2.4.0

comment:11 Changed 19 months ago by robe

Cc: jangbi882 ruvyn added

Is this still an issue or can we close out. I think I took care of most of the issues in ko_KR that have caused recent html build failures.

I do have one glaring one with reference_output.xml (but I think that might be with all because of the introduction of ST_AsMVT messed up the merge numbers).

Anyway recently build Korean html is here: http://postgis.net/docs/manual-dev/postgis-ko_KR.html

I'm still struggling with building of the PDF to understand asian characters. If BJ Jang has some suggestions on that, that would be great.

comment:12 Changed 19 months ago by robe

Resolution: worksforme
Status: newclosed

I'm closing this out since no response.

Note: See TracTickets for help on using tickets.