Opened 8 years ago

Closed 8 years ago

#3473 closed defect (fixed)

sfcgal regression failure on debbie and winnie run -possible rounding issue

Reported by: robe Owned by: robe
Priority: high Milestone: PostGIS 2.3.0
Component: QA/buildbots Version: master
Keywords: Cc:

Description

This might just be a rounding issue - perhaps we need to round the ticket results. I think all other debbie runs for other PostgreSQL are fine. Just the 9.2

http://debbie.postgis.net:8080/job/PostGIS_Regress/3189/consoleFull

 -------------- Compiler Info ------------- 
  C compiler:           gcc -g -O2
  SQL preprocessor:     /usr/bin/cpp -traditional-cpp -w -P

 -------------- Dependencies -------------- 
  GEOS config:          /var/lib/jenkins/workspace/geos/rel-3.5.1devw64/bin/geos-config
  GEOS version:         3.5.1
  GDAL config:          /var/lib/jenkins/workspace/gdal/rel-2.0w64/bin/gdal-config
  GDAL version:         2.0.2
  SFCGAL config:        /usr/bin/sfcgal-config
  SFCGAL version:       1.2.2
  PostgreSQL config:    /var/lib/jenkins/workspace/pg/rel/pg9.2w64/bin/pg_config
  PostgreSQL version:   PostgreSQL 9.2.14
  PROJ4 version:        49
  Libxml2 config:       /usr/bin/xml2-config
  Libxml2 version:      2.9.3
  JSON-C support:       yes
  PCRE support:         yes
  PostGIS debug level:  0
  Perl:                 /usr/bin/perl

PostgreSQL 9.2.14 on x86_64-unknown-linux-gnu, compiled by gcc (Debian 5.2.1-21) 5.2.1 20151003, 64-bit
  Postgis 2.3.0dev - r14709 - 2016-02-26 15:15:57
  scripts 2.3.0dev r14709
  GEOS: 3.5.1-CAPI-1.9.1 r4150
  PROJ: Rel. 4.9.2, 08 September 2015
  SFCGAL: 1.2.2

sfcgal/tickets .. failed (diff expected obtained: /var/lib/jenkins/workspace/postgis/tmp/2_3_pg9.2w64/test_117_diff)
-----------------------------------------------------------------------------
--- sfcgal/tickets_expected	2015-11-28 06:43:43.998199312 +0000
+++ /var/lib/jenkins/workspace/postgis/tmp/2_3_pg9.2w64/test_117_out	2016-02-26 15:19:09.422928933 +0000
@@ -240,4 +240,4 @@
 #2110.1|f
 #2110.2|t
 #2110.3|t
-#2145|6792004
+#2145|6792007
-----------------------------------------------------------------------------

Change History (4)

comment:1 by robe, 8 years ago

Summary: sfcgal regression failure on PostgreSQL 9.2 (debbie run) -possible rounding issuesfcgal regression failure on debbie and winnie run -possible rounding issue

I ammended the ticket. Seems winnie is complaining too but on her first run which is a 9.5 run.

Loading SFCGAL into 'postgis_reg'
  /projects/postgis/branches/2.3/regress/00-regress-install/share/contrib/postgis/sfcgal.sql
  /projects/postgis/branches/2.3/regress/00-regress-install/share/contrib/postgis/sfcgal_comments.sql
PostgreSQL 9.5.1, compiled by Visual C++ build 1800, 32-bit
  Postgis 2.3.0dev - r14709 - 2016-02-26 15:07:42
  scripts 2.3.0dev r14709
  GEOS: 3.5.0-CAPI-1.9.0 r4090
  PROJ: Rel. 4.9.1, 04 March 2015
  SFCGAL: 1.2.2

sfcgal/tickets .. failed (diff expected obtained: /projects/postgis/tmp/2.3.0dev_pg9.5_geos3.5.0_gdal2.0.1w32/test_118_diff)
-----------------------------------------------------------------------------
--- sfcgal/tickets_expected	2015-11-09 19:16:00 -0500
+++ /projects/postgis/tmp/2.3.0dev_pg9.5_geos3.5.0_gdal2.0.1w32/test_118_out	2016-02-26 10:10:38 -0500
@@ -240,4 +240,4 @@
 #2110.1|f
 #2110.2|t
 #2110.3|t
-#2145|6792004
+#2145|6792007
-----------------------------------------------------------------------------

I think debbie's failed on 9.2, because that's her touchstone build. So now I'm not sure if the sfcgal output is just wrong (should be 6792007) or if a rounding issue.

comment:2 by robe, 8 years ago

Okay looks like this was an intentional change since I see the new answer in tickets_expected for PostGIS proper. I guess someone forgot to update the SFCGAL tickets_expected. I wonder who that someone is.

comment:3 by robe, 8 years ago

Milestone: PostGIS 2.2.2PostGIS 2.3.0

comment:4 by robe, 8 years ago

Resolution: fixed
Status: newclosed

(In [14710]) Fix sfcgal tickets_expected to match postgis proper for #2145 test. Closes #3473

Note: See TracTickets for help on using tickets.