Opened 9 years ago

Last modified 7 years ago

#3340 reopened defect

populate_geometry_columns does not work on foreign tables

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS Fund Me
Component: postgis Version: 2.2.x
Keywords: history Cc:

Description

I was playing around with 9.5 trying to get my foreign tiger tables to inherit from my local tiger schema and ran into an issue that when you set a foreign table to inherit from a local one, it doesn't add on the constraints and fails because the foreign table came in with no constraints.

Anyway I thought I could solve this by using

SELECT populate_geometry_columns(false);

Nope - our populate_geometry_columns has never heard of foreign tables and just skips over them. I'm testing out my patch before I commit, but would like to get it in for 2.2.1

Change History (11)

comment:1 by robe, 9 years ago

Owner: changed from pramsey to robe

comment:2 by robe, 9 years ago

(In [14288]) addresses #3340 for 2.3 support for foreign tables in populate_geometry_columns

comment:3 by robe, 9 years ago

(In [14289]) addresses #3340 fix typo in last commit

comment:4 by robe, 9 years ago

Resolution: fixed
Status: newclosed

(In [14291]) closes #3340 for 2.2 support for foreign tables in populate_geometry_columns

comment:5 by robe, 9 years ago

Keywords: history added

comment:6 by robe, 9 years ago

Resolution: fixed
Status: closedreopened

It seems you can only add constraints in foreign tables in PostgreSQL 9.5+ so I guess I have to make function be conditional based on if its hitting 9.5 or lower. I'm not sure you can change the ype either so I might need to just take that out.

comment:7 by robe, 9 years ago

Priority: mediumblocker

comment:8 by robe, 9 years ago

(In [14446]) reverted 2.2.1 foreign table support (not safe for 2.2.1 especially since only compatible with 9.5) references #3340

comment:9 by robe, 9 years ago

Milestone: PostGIS 2.2.1PostGIS 2.3.0

comment:10 by robe, 8 years ago

Milestone: PostGIS 2.3.0PostGIS Future
Priority: blockermedium

comment:11 by robe, 7 years ago

Milestone: PostGIS FuturePostGIS Fund Me

Milestone renamed

Note: See TracTickets for help on using tickets.