populate_geometry_columns does not work on foreign tables

[robe]

I was playing around with 9.5 trying to get my foreign tiger tables to inherit from my local tiger schema and ran into an issue that when you set a foreign table to inherit from a local one, it doesn't add on the constraints and fails because the foreign table came in with no constraints.

Anyway I thought I could solve this by using

SELECT populate_geometry_columns(false);

Nope - our populate_geometry_columns has never heard of foreign tables and just skips over them. I'm testing out my patch before I commit, but would like to get it in for 2.2.1

[robe]

(In [14288]) addresses #3340 for 2.3 support for foreign tables in populate_geometry_columns

[robe]

(In [14289]) addresses #3340 fix typo in last commit

[robe]

(In [14291]) closes #3340 for 2.2 support for foreign tables in populate_geometry_columns

[robe]

It seems you can only add constraints in foreign tables in PostgreSQL 9.5+ so I guess I have to make function be conditional based on if its hitting 9.5 or lower. I'm not sure you can change the ype either so I might need to just take that out.

[robe]

(In [14446]) reverted 2.2.1 foreign table support (not safe for 2.2.1 especially since only compatible with 9.5) references #3340

[robe]

Milestone renamed