Opened 8 years ago

Closed 8 years ago

#3240 closed defect (wontfix)

liblwgeom depends on SFCGAL

Reported by: robe Owned by: pramsey
Priority: medium Milestone: PostGIS 2.2.0
Component: postgis Version: master
Keywords: Cc:


Is there a reason why my liblwgeom-2.dll now depends on SFCGAL. I recompiled SFCGAL the way I normally do and then shp2pgsql started complaining about can't find SFCGAL.

I mean it doesn't depend on GDAL, why must it depend on SFCGAL?

Change History (5)

comment:1 by pramsey, 8 years ago

What's in ./liblwgeom/Makefile ? is it linking it really?

comment:2 by robe, 8 years ago

Yes I presume this line in my Makefile does it:

ifeq (sfcgal,sfcgal)
CFLAGS += -I/projects/CGAL/rel-sfcgal-1.1.0w64gcc48/include -DHAVE_SFCGAL
LDFLAGS += -L/projects/CGAL/rel-sfcgal-1.1.0w64gcc48/lib -lSFCGAL
SA_OBJS += lwgeom_sfcgal.o

It definitely is linking because I checked my liblwgeom with dependency walker and it has a dependency on SFCGAL.

comment:3 by strk, 8 years ago

it looks like liblwgeom/ is explicitly requesting linking to it, but LDFLAGS has a -no-undefined to avoid linking to it. I guess we can just completely avoiding to link to it instead.

comment:4 by strk, 8 years ago

actually no, we cannot do w/out it as liblwgeom does use SFCGAL (ptarray_from_SFCGAL etc). I guess you didn't notice before because you were building with no SFGAL ?

comment:5 by robe, 8 years ago

Resolution: wontfix
Status: newclosed

Okay I'll close this out as a won't fix then.

Note: See TracTickets for help on using tickets.