Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3198 closed defect (fixed)

Docs for ST_AddEdgeModFace are wrong about which side of new edge gets the new face

Reported by: strk Owned by: robe
Priority: medium Milestone: PostGIS 2.0.8
Component: documentation Version: 2.0.x
Keywords: Cc:

Description

Docs state "the new face will be on the right side of new edge", while instead it's on the left side (when possible).

Change History (5)

comment:1 Changed 2 years ago by strk

Double checking, I confirm the new face is preferably on the left, and the old face on the right. "Preferably" because it is not always possible. It isn't possible, for example, when the new ring is a closed clockwise ring in the universe face. Trying to further clarify the cases in which it is not possible to maintain that preference I found that there's no testcase for adding closed edges touching the boundary of an existent face from the inside.

comment:2 Changed 2 years ago by strk

Milestone: PostGIS 2.1.8PostGIS 2.2.0
Resolution: fixed
Status: newclosed
Version: 2.1.xtrunk

I was wrong about the tests, nothing is missing as far as I can tell. Hopefully the case in which it is not possible to create the new face on the left is now clear as of r13791 (and of course I corrected it to tell that the new face would generally be on the left).

I'm re-setting milestone to 2.2.0 but only because there's no milestone for 2.1.9 (while 2.1.8 was released and it's still present in the list of milestones).

comment:3 Changed 2 years ago by strk

Milestone: PostGIS 2.2.0PostGIS 2.1.9
Version: trunk2.1.x

r13792 went in 2.1 branch (for 2.1.9). I added the missing milestone for that.

comment:4 Changed 2 years ago by strk

Milestone: PostGIS 2.1.9PostGIS 2.0.8
Version: 2.1.x2.0.x

Aaand.. r13793 goes to 2.0 (for 2.0.8) -- take this, gitflow !

comment:5 Changed 2 years ago by strk

r13794 (2.0), r13795 (2.1) and r13796 even make it valid XML ! (take this, rush)

Note: See TracTickets for help on using tickets.