DropTopology can drop the topology extension

[mwtoews]

On a test database, try the following:

CREATE EXTENSION postgis_topology;
SELECT topology.DropTopology('this does not exist');
-- Topology 'this does not exist' dropped
SELECT topology.DropTopology('topology');
-- Topology 'topology' dropped

The first DropTopology on a non-existing topology shows a misleading message. Either the return value should indicate that the topology does not exist or an exception should be raised.

The second DropTopology kills the topology extension with DROP SCHEMA '||quote_ident(atopology)||' CASCADE, which should have been avoided as topology does not have a topoid. This can be disastrous.

[mwtoews]

Generally speaking DropTopology can also drop other unrelated schemas.

CREATE SCHEMA somethingelse;
SELECT topology.DropTopology('somethingelse');
-- Topology 'somethingelse' dropped

[mwtoews]

patch for trunk

[mwtoews]

A patch on trunk is ready for review. There are only minor changes, but the indent level change adds a bit of noise to the patch. This should be applied (and modified where needed) to 2.0 and 2.1 too.

[mwtoews]

I've added another patch that fixes a few other instances where invalid topography names are attempted. The handle_invalid_toponame.diff​ patch changes these functions:

• topology.DropTopology
• topology.GetTopologyId
• topology.AddTopoGeometryColumn

[mwtoews]

correction

[mwtoews]

correction

[mwtoews]

Or on GitHub: ​https://github.com/postgis/postgis/pull/43

[strk]

r13818 in trunk (2.2.0), r13819 in 2.1 branch (2.1.9), r13820 in 2.0 branch (2.0.8) — Thanks !