A function for collecting twkb

[nicklas]

A function for collecting twkb-geometries in a collection would open some interesting possibilities.

[nicklas]

first commit r13753

Todo:

*documentation

*tests

[pramsey]

Nik, exporting the very internal "write to buffer" functions into the public API is a no-no. Figure a way to architect this internal to liblwgeom, don't drag this messy logic out into the postgis side.

[nicklas]

Oh, I didn't really realize that I was exposing them.

Does this looks better? r13771

I also realized now that I have to handle different precision on the in coming twkb-colections/geoemtries. That affects the top level bounding box.

Now the worst precision found is used. I think that is the most correct. For number of dimensions the maximum numberof dimensions found is used.

So if 1 of the in going geoemtries have z-values, the top-level bbox also have it.

[pramsey]

Would you be willing to work on this stuff in a spike? (​http://svn.osgeo.org/postgis/spike/nicklas)

[nicklas]

I realized just a few days ago that this is a needed function. I would have liked to have it in PostGIS. That is why I spent some late nights to get it there in time for feature freeze.

But I can see that it is maybe in the grey zone of what shall be in core PostGIS.

Is that your main concern or that it is just too ugly written?

[pramsey]

Both. I don't know the use case, it feels like something that is very limited to your personal interests, and it's generating scruft in the code base at the same time (new files, etc). As a bonus, it has actually broken the build for me on OSX / clang, but I'll see to that. Anyways, yeah, for something that's still conceptually in your labs, I'd rather it be worked on in a github branch or in spike.

[nicklas]

Ok, I get it.

I will take it out later today. I do of course disagree that the use case is limited to my personal interest, but I see your point.

I will try to make an extension of it. Good to learn that too, and then I can include the zoom levels .

Leave this open till it is out of the code base.

[nicklas]

Ok, its's gone in r13773

Closing this