unit test for lwgeom_mindistance2d_tolerance

[strk]

There's currently no unit test for lwgeom_mindistance2d_tolerance except for calls with a tolerance of 0.

Adding documentation for the method would also be nice.

[nicklas]

I don't really get this request.

lwgeom_mindistance2d_tolerance is just an internal function with a bad name.

raising the tolerance above 0 will stop the calculations to save some cpu-cycles.

But the logic of ST_DWithin is done on the outer function LWGEOM_dwithin.

Testing if the function stops as expected I can understand, but the result will change with small changes in code without changing output.

But where to document it? and for who?

[robe]

Milestone renamed

[komzpa]

Test is there:

​https://github.com/postgis/postgis/blob/abd79571787a7ac00b4613125fac915e4fbf8ab1/liblwgeom/cunit/cu_measures.c#L33