Opened 7 years ago

Closed 7 years ago

#3088 closed defect (fixed)

strcasestr definition in liblwgeom.h conflicts with system one

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 2.0.7
Component: postgis Version: 2.0.x
Keywords: Cc:

Description

It is not good to have strcasestr defined in liblwgeom.h as it is protected by a macro (HAVE_STRCASESTR) that is out of control.

Change History (5)

comment:2 by strk, 7 years ago

The redefinition was added in r12989 to fix #2934

comment:3 by strk, 7 years ago

Owner: changed from pramsey to strk
Status: newassigned

The only user of strcasestr seems to be lwgeom_box.c, in a function that converts all chars to lowercase right after using strcasestr, so the call could be as well removed.

comment:4 by strk, 7 years ago

Redefinition dropped with r13389 in trunk (2.2.0) — will wait for a sign of approval from bots before backporting (branches affected back to 2.0)

comment:5 by strk, 7 years ago

Milestone: PostGIS 2.1.7PostGIS 2.0.7
Resolution: fixed
Status: assignedclosed
Version: 2.1.x2.0.x

r13391 in 2.1 branch (2.1.7), r13392 in 2.0 branch (2.0.7)

Note: See TracTickets for help on using tickets.