Opened 13 years ago

Closed 11 years ago

#308 closed task (fixed)

Convert functions using *uchar serializations to use LWGEOM

Reported by: pramsey Owned by: pramsey
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description

In order to convert the whole code base to GSERIALIZED, we first have to localize the use of serialized forms to the serialize/deserialize steps. As a side benefit, code that uses the structs *should* be a lot easier to understand. One wrinkle: one of the most important functions that works directly against serialized forms is the parser. Touching the parser is scary business, but perhaps worth it.

Attachments (1)

measures.patch (18.2 KB ) - added by nicklas 12 years ago.
changing som distance functions to LWGEOM use

Download all attachments as: .zip

Change History (5)

by nicklas, 12 years ago

Attachment: measures.patch added

changing som distance functions to LWGEOM use

comment:1 by nicklas, 12 years ago

I have tried to push the *uchar use out of measures.c in the attached patch

It builds and passes cunit and regression tests in windows and linux64

Maybe someone could take a look before it goes into trunk.

/Nicklas

comment:2 by mcayland, 12 years ago

+1 with this approach - you've absolutely got it, deserialize as early as possible, serialize as late as possible. I'd be quite happy for all of the geometry functions that take SERIALIZED_FORM to disappear. In fact, when you think about you'll see that serialized form and deserialized form are simply input/output functions in exactly the same way as the GML/KML functions ;)

comment:3 by nicklas, 12 years ago

Ok, I take the chance a modified version of the patch is committed at r5807 to the trunk

there were a bug in SRID handling in the patch

/Nicklas

comment:4 by pramsey, 11 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.