Opened 15 years ago
Closed 14 years ago
#308 closed task (fixed)
Convert functions using *uchar serializations to use LWGEOM
Reported by: | pramsey | Owned by: | pramsey |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 2.0.0 |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
In order to convert the whole code base to GSERIALIZED, we first have to localize the use of serialized forms to the serialize/deserialize steps. As a side benefit, code that uses the structs *should* be a lot easier to understand. One wrinkle: one of the most important functions that works directly against serialized forms is the parser. Touching the parser is scary business, but perhaps worth it.
Attachments (1)
Change History (5)
by , 14 years ago
Attachment: | measures.patch added |
---|
comment:1 by , 14 years ago
I have tried to push the *uchar use out of measures.c in the attached patch
It builds and passes cunit and regression tests in windows and linux64
Maybe someone could take a look before it goes into trunk.
/Nicklas
comment:2 by , 14 years ago
+1 with this approach - you've absolutely got it, deserialize as early as possible, serialize as late as possible. I'd be quite happy for all of the geometry functions that take SERIALIZED_FORM to disappear. In fact, when you think about you'll see that serialized form and deserialized form are simply input/output functions in exactly the same way as the GML/KML functions
comment:3 by , 14 years ago
Ok, I take the chance a modified version of the patch is committed at r5807 to the trunk
there were a bug in SRID handling in the patch
/Nicklas
comment:4 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
changing som distance functions to LWGEOM use