Upgrade scripts -- should have create or replace for all functions

[robe]

I'm still testing, but I see you are not including all the functions in your upgrade scripts. You really should have a create or replace for all the functions regardless of which upgrade script — (we have a lot of installs out there you will find are not pure 1.5/1.4 or whatever … or whatever)

— I just tried upgrading one of my older postgis 1.5 installs (using minor upgrade) and if it were not for my wonderful postgis_comments.sql, I would not have realized a whole bunch of functions are missing.

e.g. function st_geographyfromtext(text) does not exist

— I still have yet to try on older 1.3, 1.4 — but just wanted to say we should always do a create or replace on all the functions.

[robe]

Never mind — that's not the problem. Its because its erroring out.