Comments and extension files may not be installing

[robe]

see #3003

and ​http://lists.osgeo.org/pipermail/postgis-devel/2014-September/024552.html

Doc comments building issue — apparently was a bug in 2.1.4 and a critical one. Which strk evidentally fixed in r13012

not sure if the same bug exists in 2.1.5 but need to check and patch quickly if it does

[robe]

I can't replicate this issue on my mingw64 install when installing from tar ball. I confirmed the 2.1.4 tarball already has the comments files built, so even if you don't have xsltproc installed, comments generation should not be an issue. But something does seem a bit fishy at least on FreeBSD and CentOS. Could be a difference in makes.

[robe]

pramsey can't replicate issue again on CentOS.

On dbb concluded when testing just trying to build docs, if you use make doesn't work since old school make. Have to use gmake on FreeBSD. So that might be a different issue.

So there may be nothing wrong here with extension/comments buildings as from the fact our make files assume new school make.

[robe]

Okay I see the same offensive code in 2.1 branch that was removed in trunk at r13012

though this would only be an issue building from SVN or git and not from tar ball.

[pramsey]

I fooouund it! or something very much like it. I worked through a number of vagrant installs and today was freebsd day, and this is what I found. Here's my error

---- Making all in postgis
gmake[3]: Entering directory '/usr/home/vagrant/postgis-svn/extensions/postgis'
mkdir -p sql
cat ../../postgis/postgis.sql ../../raster/rt_pg/rtpostgis.sql | /bin/sh /usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing perl ../../utils/create_unpackaged.pl postgis > sql/postgis--unpackaged--2.2.0dev.sql
cannot open /usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing: No such file or directory
Makefile:50: recipe for target 'sql/postgis--unpackaged--2.2.0dev.sql' failed
gmake[3]: *** [sql/postgis--unpackaged--2.2.0dev.sql] Error 2
gmake[3]: *** Deleting file 'sql/postgis--unpackaged--2.2.0dev.sql'

I do have xsltproc installed, and a clean build will create the comments in the doc directory. The problem is with PGXS, which is over-writing our value of $(PERL) with it's own value, which is "/bin/sh /usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing". Rather than, say "/usr/bin/perl". This is the *second* hell nonsense I endured during my platform playing thanks to PGXS, which makes using pre-built postgresql packages really quite hard.

[pramsey]

But now examining the code I see nowhere that PERL is not carefully guarded and over-ridden with a local version.