Opened 10 years ago
Closed 9 years ago
#2892 closed defect (fixed)
cunit for cu_varint warnings
Reported by: | robe | Owned by: | robe |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 2.2.0 |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
These show on winnie after r12883 commit. Haven't checked debbie. I think these ones are my fault since I had taken out the hexbytes_from_bytes def in cu_varint.c at r12871 because I saw it already defined.
cu_varint.c:34:2: warning: implicit declaration of function 'hexbytes_from_bytes' [-Wimplicit-function-declaration] hex = hexbytes_from_bytes(buf,size); ^ cu_varint.c:34:6: warning: assignment makes pointer from integer without a cast [enabled by default] hex = hexbytes_from_bytes(buf,size); ^ cu_varint.c:39:3: warning: implicit declaration of function 'lwfree' [-Wimplicit-function-declaration] lwfree(hex); ^ cu_varint.c: In function 'do_test_s32_varint': cu_varint.c:54:6: warning: assignment makes pointer from integer without a cast [enabled by default] hex = hexbytes_from_bytes(buf,size); ^ cu_varint.c: In function 'do_test_u64_varint': cu_varint.c:74:6: warning: assignment makes pointer from integer without a cast [enabled by default] hex = hexbytes_from_bytes(buf,size); ^ cu_varint.c: In function 'do_test_s64_varint': cu_varint.c:94:6: warning: assignment makes pointer from integer without a cast [enabled by default] hex = hexbytes_from_bytes(buf,size); ^ cu_varint.c: In function 'test_varint': cu_varint.c:152:2: warning: this decimal constant is unsigned only in ISO C90 [enabled by default] do_test_s32_varint(-2147483648, 5, "FFFFFFFF0F"); ^
Change History (5)
comment:1 by , 10 years ago
Owner: | changed from | to
---|
comment:2 by , 10 years ago
Strange I have missed it. I thoufht I looked for all twkb related warnings.
comment:3 by , 10 years ago
Regina I think it is me who messed things up by changing header files in cu_varint.
I don't have an environment to test until tomorrow. But if you have time maybe you could test by changing back to the liblwgeom_internal.h header instead of varint.h. So undo this commit: http://trac.osgeo.org/postgis/changeset/12878/trunk/liblwgeom/cunit/cu_varint.c Then it should see both the hex-reader and lwfree function I guess.
comment:4 by , 10 years ago
committed r12884. That seems to have done the trick for all warnings except one. Thanks Nicklas.
Only one left is:
cu_varint.c: In function 'test_varint': cu_varint.c:153:2: warning: this decimal constant is unsigned only in ISO C90 [enabled by default] do_test_s32_varint(-2147483648, 5, "FFFFFFFF0F");
comment:5 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
confirmed debbie shows the same warning.