Opened 6 years ago

Closed 6 years ago

#2796 closed patch (fixed)

sfcgal_comments.sql missing for regress testing install

Reported by: robe Owned by: colivier
Priority: medium Milestone: PostGIS 2.2.0
Component: sfcgal Version: master
Keywords: Cc:

Description

Okay winnie is now passing the sfcgal tests but I noticed the sfcgal_comments.sql install missing in her output:

TMPDIR is /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.5.0dev_gdal1.10.0w64
Creating database 'postgis_reg' 

Loading PostGIS into 'postgis_reg' 
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis.sql

  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis_comments.sql
Loading SFCGAL into 'postgis_reg'
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/sfcgal.sql

PostgreSQL 9.3.4, compiled by Visual C++ build 1600, 64-bit
  Postgis 2.2.0dev
 - r12703
 - 2014-06-29 21:28:47
  scripts 2.2.0dev r12703
  GEOS: 3.5.0dev-CAPI-1.9.0 r3989
  PROJ: Rel. 4.8.0, 6 March 2012
  SFCGAL: 1.0.4

The comments seem to be installed fine for create extension.

We install the comments during regress as well to catch incongruencies between the documentation and what is actually implemented.

Attachments (1)

2796.patch (1.0 KB) - added by vmo 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by vmo

Attachment: 2796.patch added

comment:1 Changed 6 years ago by vmo

The sfcgal_comments.sql was missing from Makefile.comments.in (patch)

comment:2 Changed 6 years ago by robe

Type: defectpatch

comment:3 Changed 6 years ago by pramsey

Resolution: fixed
Status: newclosed

Trunk at r12708

Note: See TracTickets for help on using tickets.