Opened 10 years ago

Closed 10 years ago

#2794 closed defect (fixed)

regress sfcgal.sql install script fails to install with make check RUNTESTFLAGS=-v

Reported by: robe Owned by: colivier
Priority: high Milestone: PostGIS 2.1.6
Component: sfcgal Version: master
Keywords: Cc:

Description

Turned on the switch to have winnie start regress testing sfcgal and still getting errors.

PostgreSQL 9.3.4, compiled by Visual C++ build 1600, 64-bit
  Postgis 2.2.0dev
 - r12700
 - 2014-06-29 05:58:40
  scripts 2.2.0dev r12700
  GEOS: 3.5.0dev-CAPI-1.9.0 r3989
  PROJ: Rel. 4.8.0, 6 March 2012
Running tests

 loader/Point .............. ok 

 loader/PointM .............. ok 

 loader/PointZ .............. ok 

 loader/MultiPoint .............. ok 

 loader/MultiPointM .............. ok 

 loader/MultiPointZ .............. ok 

 loader/Arc .............. ok 

 loader/ArcM .............. ok 

 loader/ArcZ .............. ok 

 loader/Polygon .............. ok 

 loader/PolygonM .............. ok 

 loader/PolygonZ .............. ok 

 loader/TSTPolygon ......... ok 

 loader/TSIPolygon ......... ok 

 loader/TSTIPolygon ......... ok 

 loader/PointWithSchema ..... ok 

 loader/NoTransPoint ......... ok 

 loader/NotReallyMultiPoint ......... ok 

 loader/MultiToSinglePoint ......... ok 

 loader/ReprojectPts ........ ok 

 loader/ReprojectPtsGeog ........ ok 

 loader/Latin1 .... ok 
 loader/Latin1-implicit .... ok 

 dumper/literalsrid ....... ok 

 dumper/realtable ....... ok 

 binary .. ok 
 regress .. ok 

 regress_index .. ok 
 regress_index_nulls .. ok 

 regress_selectivity .. ok 
 lwgeom_regress .. ok 
 regress_lrs .. ok 
 removepoint .. ok 
 setpoint .. ok 

 simplify .. ok 
 snaptogrid .. ok 
 summary .. ok 
 affine .. ok 
 empty .. ok 

 forcecurve .. ok 
 measures .. ok 

 legacy .. ok 
 long_xact .. ok 

 ctors .. ok 
 sql-mm-serialize .. ok 
 sql-mm-circularstring .. ok 
 sql-mm-compoundcurve .. ok 

 sql-mm-curvepoly .. ok 
 sql-mm-general .. ok 
 sql-mm-multicurve .. ok 
 sql-mm-multisurface .. ok 

 polyhedralsurface .. ok 
 polygonize .. ok 
 postgis_type_name .. ok 
 geography .. ok 

 out_geometry .. ok 
 out_geography .. ok 
 in_geohash .. ok 

 in_gml .. ok 

 in_kml .. ok 
 iscollection .. ok 
 regress_ogc .. ok 
 regress_ogc_cover .. ok 
 regress_ogc_prep .. ok 

 regress_bdpoly .. ok 
 regress_proj .. ok 
 regress_management .. ok 
 dump .. ok 

 dumppoints .. ok 
 boundary .. ok 

 wmsservers .. ok 
 wkt .. ok 
 wkb .. ok 

 tickets .. ok 

 typmod .. ok 
 remove_repeated_points .. ok 
 split .. ok 

 relate .. ok 
 bestsrid .. ok 

 concave_hull .. ok 

 twkb .. ok 
 hausdorff .. ok 
 regress_buffer_params .. ok 
 offsetcurve .. ok 

 relatematch .. ok 
 isvaliddetail .. ok 
 sharedpaths .. ok 
 snap .. ok 
 node .. ok 

 unaryunion .. ok 
 clean .. ok 

 relate_bnr .. ok 
 delaunaytriangles .. ok 
 in_geojson .. ok 
 regress_sfcgal .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.5.0dev_gdal1.10.0w64/test_95_diff)
-----------------------------------------------------------------------------
--- regress_sfcgal_expected	2014-06-28 18:10:01 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.5.0dev_gdal1.10.0w64/test_95_out	2014-06-29 02:06:03 -0400
@@ -1,14 +1,14 @@
-postgis_sfcgal_version|1
-ST_Tesselate|GEOMETRYCOLLECTION(POINT(4 4),TIN(((0 1,1 0,1 1,0 1)),((0 1,0 0,1 0,0 1))))
-ST_3DArea|1
-ST_Extrude_point|LINESTRING Z (0 0 0,1 0 0)
-ST_Extrude_line|POLYHEDRALSURFACE Z (((0 0 0,1 0 0,1 1 0,0 1 0,0 0 0)))
-ST_Extrude_surface|POLYHEDRALSURFACE Z (((1 1 0,1 0 0,0 1 0,1 1 0)),((0 1 1,1 0 1,1 1 1,0 1 1)),((1 0 0,0 0 0,0 1 0,1 0 0)),((0 1 1,0 0 1,1 0 1,0 1 1)),((1 0 0,1 1 0,1 1 1,1 0 1,1 0 0)),((1 1 0,0 1 0,0 1 1,1 1 1,1 1 0)),((0 1 0,0 0 0,0 0 1,0 1 1,0 1 0)),((0 0 0,1 0 0,1 0 1,0 0 1,0 0 0)))
-ST_ForceLHR|POLYGON((0 0,1 0,1 1,0 1,0 0))
-ST_Orientation_1|-1
-ST_Orientation_2|1
-ST_MinkowskiSum|MULTIPOLYGON(((0 0,1 0,5 0,5 1,4 1,0 1,0 0)))
-ST_StraightSkeleton|MULTILINESTRING((0 0,0.5 0.5),(1 0,0.5 0.5),(1 1,0.5 0.5),(0 1,0.5 0.5))
+ERROR:  function postgis_sfcgal_version() does not exist at character 56
+ERROR:  function st_tesselate(unknown) does not exist at character 34
+ERROR:  function st_3darea(unknown) does not exist at character 21
+ERROR:  function st_extrude(unknown, integer, integer, integer) does not exist at character 38
+ERROR:  function st_extrude(unknown, integer, integer, integer) does not exist at character 48
+ERROR:  function postgis_sfcgal_version() does not exist at character 41
+ERROR:  function st_forcelhr(unknown) does not exist at character 33
+ERROR:  function st_forcelhr(unknown) does not exist at character 43
+ERROR:  function st_orientation(geometry) does not exist at character 28
+ERROR:  function st_minkowskisum(unknown, unknown) does not exist at character 37
+ERROR:  function st_straightskeleton(unknown) does not exist at character 41
 intersection_geos|POINT(0 0)
 intersection_sfcgal|POINT(-0 -0)
 ERROR:  Can't find foo geometry backend
-----------------------------------------------------------------------------

 sfcgal/empty .. ok 
 sfcgal/geography .. ok 

 sfcgal/legacy .. ok 

 sfcgal/measures .. ok 
 sfcgal/regress_ogc_prep .. ok 
 sfcgal/regress_ogc .. ok 
 sfcgal/regress .. ok 

 sfcgal/tickets .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.5.0dev_gdal1.10.0w64/test_103_diff)
-----------------------------------------------------------------------------
--- sfcgal/tickets_expected	2014-06-28 18:09:59 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.5.0dev_gdal1.10.0w64/test_103_out	2014-06-29 02:06:07 -0400
@@ -95,7 +95,7 @@
 #835.11|MULTILINESTRING EMPTY
 #835.12|MULTIPOLYGON EMPTY
 #650|MULTIPOINT(0 0,1 1,2 2)
-#667|SRID=4326;CURVEPOLYGON(CIRCULARSTRING(30 40,-50 39.9999999999999,30 40))
+ERROR:  function postgis_sfcgal_version() does not exist at character 118
 #677|1121395
 #680|01d107000000000000000024c000000000000049400000000000000040
 #681a|
-----------------------------------------------------------------------------

 sfcgal/concave_hull .. ok 

 sfcgal/wmsservers .. ok 
 uninstall .  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/uninstall_postgis.sql

. ok (4112
)

Run tests: 106
Failed: 2

Makefile:210: recipe for target `check' failed
make[1]: *** [check] Error 2
make[1]: Leaving directory `/projects/postgis/branches/2.2/regress'
GNUmakefile:14: recipe for target `check' failed
make: *** [check] Error 1

Change History (6)

comment:1 by robe, 10 years ago

It's almost as if the sfcgal.sql script was not installed.

comment:2 by robe, 10 years ago

Priority: mediumhigh
Summary: winnie regress failures for sfcgal - 2 errorswinnie regress failures for sfcgal - 2 errors - seems scfgal.sql not installed

Really odd. Seems winnie is not installing sfcgal script but even more odd, messages are completely different.

On my local desktop running PostgreSQL 9.4beta1 I see this:

Creating database 'postgis_reg' 
Loading PostGIS into 'postgis_reg' 
Loading SFCGAL into 'postgis_reg'
PostgreSQL 9.4beta1, compiled by Visual C++ build 1800, 32-bit
  Postgis 2.2.0dev
 - r12688
 - 2014-06-29 18:42:33
  scripts 2.2.0dev r12688
  GEOS: 3.5.0dev-CAPI-1.9.0 r3985
  PROJ: Rel. 4.8.0, 6 March 2012
  SFCGAL: 1.0.4

and all tests pass.

and on winnie on her first test which fails the 2.2 chain I see this:

Creating database 'postgis_reg' 
Loading PostGIS into 'postgis_reg' 
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis.sql
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis_comments.sql
PostgreSQL 9.3.4, compiled by Visual C++ build 1600, 64-bit
  Postgis 2.2.0dev
 - r12702
 - 2014-06-29 18:50:20
  scripts 2.2.0dev r12702
  GEOS: 3.5.0dev-CAPI-1.9.0 r3989
  PROJ: Rel. 4.8.0, 6 March 2012

note absense of sfcgal and message for install is totally different. I did a recent complete checkout on winnie and will do same on mine to rule out recent change or dirty stuff left. Also bothered that the version number output on my desktop is wrong. It's almost like its using CREATE EXTENSION since the version is is spitting out is version I have installed in my PostgreSQL instance which is a recent build I installed from winnie.

Perhaps its not doing the same on winnie — because I didn't do a make install, so she might not have the extension files loaded in her instance.

comment:3 by robe, 10 years ago

Summary: winnie regress failures for sfcgal - 2 errors - seems scfgal.sql not installedregress sfcgal.sql install script fails to install with make check RUNTESTFLAGS=-v

AHA I found the smoking done - winnie was running with

make check  RUNTESTFLAGS=-v

thus the more descriptive install message

While my dev box is running with

make check

changed my desktop to do the same and it fails too.

comment:4 by robe, 10 years ago

Resolution: fixed
Status: newclosed

fixed at r12703

comment:5 by strk, 10 years ago

Milestone: PostGIS 2.2.0PostGIS 2.1.6
Resolution: fixed
Status: closedreopened

I think this should be backported, see #3017

comment:6 by strk, 10 years ago

Resolution: fixed
Status: reopenedclosed

Backported to 2.1 branch as r13191

Note: See TracTickets for help on using tickets.