ST_Minkowski and ST_IsPlanar are documented but not installed

[robe]

I tried installing the sfcgal_comments.sql after installing sfcgal.sql. Comments did not install.

1) junk at top. I'll take care of this one 2) Two functions in comments don't appear in my sfcgal install —

ST_Minkowski and ST_Planar.

[vmo]

The attached patch should solve this.

[vmo]

Replying to vmo:

The attached patch should solve this.

Apparently the patch does not work properly.

The <sect1> wants a <title>, but when the comments are generated, the title ends up in the comments (junk).

[robe]

I committed patch at r12626. I revised to move the introduction stuff into the more standard section abstract rather than creating a whole new section and ref id which would cause problems in other ways.

I see you added ST_3DIntersection so that is good but ST_Minkowski was still a problem

I fixed those in r12627 and fixed my template in r12628.

We still have the issue though that ST_IsPlanar is documented, but I don't see it installed. Is this something that should be installed or should it be removed from docs?

[vmo]

Replying to robe:

I committed patch at r12626. I revised to move the introduction stuff into the more standard section abstract rather than creating a whole new section and ref id which would cause problems in other ways.

Thanks a lot.

We still have the issue though that ST_IsPlanar is documented, but I don't see it installed. Is this something that should be installed or should it be removed from docs?

What do you mean by 'not installe' ?

ST_IsPlanar is one of the functions that is replaced when setting postgis.backend to sfcgal.

[robe]

vmo,

But we don't have a GEOS provided ST_IsPlanar function. It's my understanding the backend swap only applies for functions that both GEOS and SFCGAL provide and then in th aht case, the SFCGAL ref guide wouldn't have any extra documentation for it since we would make note of it as we do for ST_3DDistance — ​http://postgis.net/docs/manual-dev/ST_3DDistance.html

[vmo]

Sorry, I did not read the subject correctly, thanks for the explanation, patch above installs ST_IsPlanar.

[robe]

should be fixed now. Still have to test.

[robe]

fixed at r12643

[robe]

backported some of the fixes to 2.1 at r12646 , and removed ST_IsPlanar from 2.1 docs (since I can't add the function back since it would change exposed api).