Opened 10 years ago

Closed 9 years ago

#2669 closed defect (fixed)

cunit warnings unsigned int ISO C90 assumption and extra tokens

Reported by: robe Owned by: pramsey
Priority: medium Milestone: PostGIS 2.2.0
Component: postgis Version: 2.1.x
Keywords: Cc:

Description

I'm seeing some annoying warnings on winnie's compile. They probably are harmless since they are on cunit, but could possibly cause false negatives

cu_tree.c:19:24: warning: extra tokens at end of #include directive [enabled by default]
 #include "lwgeodetic.h";
                        ^
cu_tree.c:20:29: warning: extra tokens at end of #include directive [enabled by default]
 #include "lwgeodetic_tree.h";

cu_algorithm.c: In function 'test_geohash_point_as_int':
cu_algorithm.c:889:2: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
  CU_ASSERT_EQUAL(gh, (unsigned int)3440103613);
  ^
cu_algorithm.c:892:2: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
  CU_ASSERT_EQUAL(gh, (unsigned int)3982480893);
  ^
cu_algorithm.c:895:2: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
  CU_ASSERT_EQUAL(gh, (unsigned int)4166944232); 
  ^

Note that winnie is running gcc 4.8.0 for 9.3 builds and I think gcc 4.8 throws more warnings about using legacy constructs.

Change History (1)

comment:1 by pramsey, 9 years ago

Resolution: fixed
Status: newclosed

These are already gone. Killed a few other ones at r13765

Note: See TracTickets for help on using tickets.