Bots are mad -- can't compile 2.2 chain

[robe]

Both winnie and debbie are angry with your 2.2 changes.

Both are registering these failures:

This is so badly broken.  You've angered both bots in the 2.2 chain.

Both winnie and debbie are reporting:


on debbie:

{{{
make[1]: Entering directory `/var/lib/jenkins/workspace/postgis/branches/2.2/liblwgeom'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/liblwgeom'
---- Making all in libpgcommon
make[1]: Entering directory `/var/lib/jenkins/workspace/postgis/branches/2.2/libpgcommon'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/libpgcommon'
---- Making all in postgis
make[1]: Entering directory `/var/lib/jenkins/workspace/postgis/branches/2.2/postgis'
/usr/bin/perl ../utils/postgis_proc_upgrade.pl postgis.sql UNUSED > postgis_upgrade.sql.in
Type of arg 1 to keys must be hash (not private variable) at ../utils/postgis_proc_upgrade.pl line 115, near "$objs ) "
Execution of ../utils/postgis_proc_upgrade.pl aborted due to compilation errors.
make[1]: *** [postgis_upgrade.sql.in] Error 9
make[1]: *** Deleting file `postgis_upgrade.sql.in'
make[1]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/postgis'
make: *** [all] Error 1
}}}


{{{

}}}


Winnie
{{{
/bin/perl -lpe "s'MODULE_PATHNAME'\$libdir/postgis-2.2'g" > postgis.sql
/bin/perl ../utils/create_undef.pl postgis.sql 93 > uninstall_postgis.sql
/bin/perl ../utils/postgis_proc_upgrade.pl postgis.sql UNUSED > postgis_upgrade.sql.in
Type of arg 1 to keys must be hash (not private variable) at ../utils/postgis_proc_upgrade.pl line 115, near "$objs ) "
Execution of ../utils/postgis_proc_upgrade.pl aborted due to compilation errors.
Makefile:167: recipe for target `postgis_upgrade.sql.in' failed
make[1]: *** [postgis_upgrade.sql.in] Error 255
make[1]: *** Deleting file `postgis_upgrade.sql.in'
make[1]: Leaving directory `/projects/postgis/branches/2.2/postgis'
GNUmakefile:14: recipe for target `all' failed
}}}

[robe]

forgot to note that failure started happening with this commit:

r12271

[strk]

What version of Perl on the bots ? I'm looking at the error..

[strk]

Let's see if they like r12280

[strk]

It doesn't seem they liked it, but the report email I get is useful. Any link I click on ask me for a password, which is frustrating.

Here's the full body of the mail I receive:

Date: Tue, 25 Feb 2014 00:38:27 -0800 (PST)                                     
From: debbie@postgis.net                                                        
To: strk@keybit.net                                                             
Subject: Build failed in Jenkins: PostGIS_2.2 #242                              
In-Reply-To: <460399107.18.1393275183502.JavaMail.jenkins@30266-3-1329969>      
                                                                                
See <http://debbie.postgis.net:8080/job/PostGIS_2.2/242/changes>                
                                                                                
Changes:                                                                        
                                                                                
[Sandro Santilli] Qualify hash as such                                          
                                                                                
Attempt to fix #2656                                                            
                                                                                
------------------------------------------
Started by an SCM change                                                        
Building in workspace <http://debbie.postgis.net:8080/job/PostGIS_2.2/ws/>      
Updating http://svn.osgeo.org/postgis/trunk at revision '2014-02-25T00:36:25.207-0800'
U         utils/postgis_proc_upgrade.pl                                         
At revision 12280                                                               
Waiting for the completion of PostGIS_src_tar                                   
PostGIS_src_tar #1357 completed. Result was SUCCESS   
Build step 'Trigger/call builds on other projects' changed build result to SUCCESS                                                                         
Waiting for the completion of PostGIS_Regress_9.2  
PostGIS_Regress_9.2 #705 completed. Result was FAILURE  
Build step 'Trigger/call builds on other projects' marked build as failure  

[robe]

nope from: ​http://debbie.postgis.net:8080/job/PostGIS_Regress/3359/console

make[2]: Entering directory `/var/lib/jenkins/workspace/postgis/branches/2.2/extensions/postgis_tiger_geocoder'
for OLD_VERSION in 2.0.0 2.0.1 2.0.2 2.0.3 2.0.4 2.1.0 2.1.1; do \
  	  cat ../postgis_extension_helper.sql sql_bits/remove_from_extension.sql.in sql/tiger_geocoder_upgrade_minor.sql sql_bits/mark_editable_objects.sql.in sql_bits/tiger_geocoder_comments.sql ../postgis_extension_helper_uninstall.sql > sql/postgis_tiger_geocoder--$OLD_VERSION--2.2.0dev.sql; \
	done
make[2]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/extensions/postgis_tiger_geocoder'
---- Making all in postgis_topology
make[2]: Entering directory `/var/lib/jenkins/workspace/postgis/branches/2.2/extensions/postgis_topology'
make[2]: *** No rule to make target `../../topology/topology_upgrade_22_minor.sql', needed by `sql/topology_upgrade_minor.sql'.  Stop.
make[2]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/extensions/postgis_topology'
make[1]: *** [all] Error 1
make[1]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/extensions'
make: *** [all] Error 1

[strk]

robe, can you make it so the link you posted gets into my mailbox when the bot complains, rather than receiving those blind roads links ?

I'm expecting another mail due to r12281 …

[robe]

hmm not sure. I'll try when I have time. I don't think there is too much I can do about the mail though rearranging the cascading of the jobs might help.

[robe]

Your last commit seems to have fixed the issue.