Opened 10 years ago

Closed 8 years ago

#2531 closed enhancement (fixed)

Autogenerate the extension unpackaged script

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.2.0
Component: build/upgrade/install Version: master
Keywords: Cc:

Description (last modified by robe)

Right now before release, we generate the unpackaged scripts used to

CREATE EXTENSION postgis FROM unpackaged;

by installing postgis with CREATE EXTENSION and then running a query to see what is in the package. strk is working on script to generate the unpackaged script by sourcing the .sql files we generate. This will simplify our packaging logic and also ensure the unpackaged is always in synch at all times.

For testing the quality of it I propose as part of installcheck (postcheck) #2358

  1. Count number of objects before PostGIS install
  1. Install PostGIS using non-extension scripts
  1. Run the generated CREATE EXTENSION postgis FROM unpackaged;
  1. Run DROP EXTENSION postgis;
  1. The number of objects in data install should be the same as 1

Change History (7)

comment:1 by robe, 10 years ago

Description: modified (diff)

comment:2 by strk, 10 years ago

The script creating the "from unpackaged" thing is in progress, and promising. And exposing few bugs here and there. A couple already fixed and pushed (duplicated signatures in postgis.sql), another in raster which I'll open a ticket for.

comment:3 by strk, 10 years ago

Filed ticket #2532 for the raster commutators

comment:4 by strk, 10 years ago

And #2533 is for the duplicated signatures

comment:5 by strk, 10 years ago

See how you like r12104 — it only does "postgis" extension but it could easily also do topology and geocoder and what not.

comment:6 by strk, 10 years ago

r12105 implements it for "postgis_topology". "postgis_tiger_geocoder" is still left out from the fun.

comment:7 by strk, 8 years ago

Resolution: fixed
Status: newclosed

I'll consider this done. The tiger geocoder I don't usually build so no idea if it can be automated in the same way. If you think so (and that it should) please file a new ticket.

Note: See TracTickets for help on using tickets.