failing on dumper-shp.prj No such file regress test

[robe]

this file I see generated on both winnie and debbie, in right temp folder, but both are registering as can't find the file.

Might be a timing issue, a permissions issue, or the code is checking default location and lying about the path.

Only thing common about both winnie and debbie is they override the temp folder

[robe]

My windows 7 desktop is failing as well with similar issue. So not just the bots. I'm configured to also use custom tmp directory. Strk can you try with custom folder to rule that out as the culprit.

dumper/literalsrid ..... failed (diff expected obtained: /projects/postgis/tmp/2.2_pg9.3w64/test_24_diff)
                                                                               dumper/realtable ....... ok
                                                                              sh: /projects/postgis/tmp/2.2_pg9.3w64/test_25_tmp: Permission denied
                                                                               failed (Unable to run sql script dumper/realtable-post.sql: /projects/postgis/tmp/2.2_pg9.3w64/test_25_tmp)
                                                                               ... but cleanup sql failed! binary .. ok

my test_24_diff just has

diff: /projects/postgis/tmp/2.2_pg9.3w64/dumper-shp.prj: No such file or directory

But the file IS THERE.

[robe]

pramsey got the same error, but then his magically fixed itself after he cleared out his temp directory.

I cleared mine out and also tried using default temp and still fails for it.

Could it be a timing issue? Is it guaranteed they work in series that the dump happens and completes before your check or are they parallel jobs.

[pramsey]

One mystery solved: there is a second dumper test after the first one, I think it's creating the .prj file which is missing on the first test.

[strk]

Ouch, found the problem. Indeed there's another false negative then, due to the presence of a .prj file where there shouldn't be one. I'll first fix that, then will fix the test itself (test is bogus because it uses a SRID=4326 while only SRID=1 is expected to produce a .prj file).

[strk]

r12032 should give us a solid failure r12033 would fix the failure

[robe]

better Debbie is happy but winnie still has a problem

 /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.4.2_gdal1.10.0w64/test_24_tmp: Permission denied
Cannot open log file /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.4.2_gdal1.10.0w64/test_24_tmp
 failed (Unable to run sql script dumper/literalsrid-post.sql: /projects/postgis/tmp/2.2.0dev_pg9.3_geos3.4.2_gdal1.10.0w64/test_24_tmp)

I ran into the same issue on my windows 7 box and hoped it would go away when you fixed this, but it didn't. What is this test_24_tmp it tries to open? I don't see one so must be some transient thing

[strk]

It's a temporary file where the output of an sql test is written. The 24th test run, in this case. You don't see why due to the Permission denied error, sounds like

[robe]

I forget whether the error went away when I put in all those sleep commands pramsey had suggested. I think it might have gone away so maybe it's being read before its being created. I think windows throws a permission denied if there is a write lock on a file.

[strk]

Can you run the tester manually and see what happens ?

regress/run_test.pl regress/dumper/literalsrid

[robe]

I ran and got this:

regress/dumper/literalsrid ....... ok
                                      sh: /projects/postgis/tmp/2.2_pg9.3w64/test_1_tmp: Permission denied
                                                                                                           failed (Unable to run sql script regress/dumper/literalsrid-post.sql: /projects/postgis/tmp/2.2_pg9.3w64/test_1_tmp)
                                                                                                                                                    ... but cleanup sql failed! uninstall .. ok (4112

[robe]

I wonder if it has anything to do with the fact that the temp file is reused. I put in print statements

 regress/dumper/literalsrid .psql -v "VERBOSITY=terse" -tXA postgis_reg < regress/dumper/literalsrid-pre.sql > /projects/postgis/tmp/2.2_pg9.3w64/test_1_tmp 2>&1...... ok
                                                                                                                                                    psql -v "VERBOSITY=terse" -tXA postgis_reg < regress/dumper/literalsr
is/tmp/2.2_pg9.3w64/test_1_tmp: Permission denied
                                                  failed (Unable to run sql script regress/dumper/literalsrid-post.sql: /projects/postgis/tmp/2.2_pg9.3w64/test_1_tmp)
)                                                                                                                                                    ... but cleanup sql failed! uninstall .. ok (4112

 Run tests: 2

though i would expect loader/PointWithSchema.sql to have same issue since it too has a pre and post.sql

[robe]

I'm closing this ticket out because the core issue of dumper-shp.prj is fixed. Now we are left with permission denieds on windows

[strk]

I guess it could be about reuse: first file is created with read-only perms (umask?) and second one is forbidden to override. I'll try using different names for different (sub) tests .

[strk]

please try r12037

[strk]

This was closed long ago, other issue (also fixed) belongs to #2509