Opened 9 years ago

Closed 7 years ago

#2335 closed defect (fixed)

rename internal LWGEOMWKB to be a bit more clear it is for EWKB

Reported by: robe Owned by: pramsey
Priority: medium Milestone: PostGIS 2.2.0
Component: postgis Version: master
Keywords: Cc:

Description

I normally don't get offended by naming conventions, but this one is really offending my sense of etiquette.

As noted in #2332

We have two internal functions: LWGEOMFromWKB (which is used for ewkb conversion) - http://postgis.net/docs/doxygen/2.1/d9/d6e/lwgeom__inout_8c_source.html#l00330

and LWGEOM_from_WKB ( http://postgis.net/docs/doxygen/2.1/da/d94/lwgeom__ogc_8c_source.html#l00790 )(which is used for plain WKB conversion). From the anming its really hard to know thier is a difference. If we can't consolidate these, can we at least call LWGEOMFromWKB LWGEOMFromeWKB or something so its clearer its purpose?

Change History (2)

comment:1 Changed 9 years ago by robe

Milestone: PostGIS 2.1.0PostGIS 2.2.0

comment:2 Changed 7 years ago by pramsey

Resolution: fixed
Status: newclosed

Done, r13451

Note: See TracTickets for help on using tickets.