Opened 7 years ago

Closed 4 years ago

#2301 closed defect (fixed)

ST_DelaunayTriangles needs 3D tests

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.2.0
Component: postgis Version: master
Keywords: Cc: nw

Description

I just noticed the ST_DelaunayTriangles is missing 3D tests which I noticed when Nathan committed his TIN support in #1898.

We are sort of inviolation of a pseudo policy that we stated 3D functions would be prefixed with 3D. But ST_DelaunayTriangles supports (well 2.5D). I suspect the tests don't have it because the 3D support came in 3.4 geos after the ST_DelaunayTriangles function was created.

Change History (6)

comment:1 Changed 7 years ago by robe

Summary: ST_DeluanayTriangles needs 3D testsST_DelaunayTriangles needs 3D tests

comment:2 Changed 7 years ago by nw

Cc: nw added

comment:3 Changed 6 years ago by strk

Where's the policy written ? I don't like it that much. I mean... I like input-based output dimension. Ok to have 3D or 2D prefixes, but that'd be in addition to the "automatic" signature. Or would they also need a 3DM prefix then ?

comment:4 Changed 5 years ago by pramsey

Owner: changed from pramsey to colivier

comment:5 Changed 4 years ago by robe

Owner: changed from colivier to strk

This is really strk's not olivier's it is a GEOS function

comment:6 Changed 4 years ago by strk

Resolution: fixed
Status: newclosed

Done with r14126

Note: See TracTickets for help on using tickets.