Opened 10 years ago

Closed 10 years ago

#2121 closed defect (fixed)

stop validating dtd for comments generation

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.0.3
Component: build/upgrade/install Version: 2.0.x
Keywords: Cc:

Description

I am so tired of gettting build bot failures everytime dtd validation checks fail. This often happens because of network failures downloading dtd.

I propose we change the comments generation sections to the form

postgis_comments.sql: ./xsl/postgis_comments.sql.xsl $(XML_INPUTS)
	$(XSLTPROC) --novalid ./xsl/postgis_comments.sql.xsl postgis-out.xml > $@

Change History (7)

comment:1 by robe, 10 years ago

Well this is mighty annoying, it appears I need validation for raster because of the use of pi in:

http://www.postgis.org/documentation/manual-svn/RT_ST_Aspect.html

Can we do without the pi symbol or maybe locally define it in postgis.xml

without that I get a parse error on use of π

comment:2 by Bborie Park, 10 years ago

Oh wow. Completely forgot I'm using the actual pi character. I'll remove that…

comment:3 by Bborie Park, 10 years ago

And the actual pi character is only found in -trunk, not 2.0.

comment:4 by Bborie Park, 10 years ago

I've removed the use of the html code for pi in r10772.

comment:5 by robe, 10 years ago

yah 2.0 didn't seem to give me issue when I changed to —no-valid. I hard-coded on winnie to see if it helps her stop whining a bit. i'll try that next for 2.1 after I retest.

comment:6 by robe, 10 years ago

Done for 2.1 at r10775

comment:7 by robe, 10 years ago

Resolution: fixed
Status: newclosed

Done for 2.0 at r10794

Note: See TracTickets for help on using tickets.