Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2118 closed patch (fixed)

Implement ST_Boundary(Triangle)

Reported by: strk Owned by: nw
Priority: medium Milestone: PostGIS 2.1.0
Component: postgis Version: master
Keywords: history Cc:

Description

Seems to be a useful thing to have...

Attachments (1)

triboundary.patch (2.0 KB) - added by nw 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by robe

Milestone: PostGIS 2.1.0PostGIS Future

Changed 7 years ago by nw

Attachment: triboundary.patch added

comment:2 Changed 7 years ago by nw

Owner: changed from pramsey to nw
Status: newassigned

The attached patch will implement this. A polygon would be pretty simple to do without going to GEOS also, though not trivial like the triangle.

comment:3 Changed 7 years ago by robe

Milestone: PostGIS FuturePostGIS 2.1.0

seems harmless enough.

comment:4 Changed 7 years ago by robe

Resolution: fixed
Status: assignedclosed

committed at r11358 . If you can get in a patch for TIN before end next week, I might be able to commit (and call this fully supporting tins in docs). Right now (I'd have to put in just a note that it supports triangle, which ain't bad since I think ST_Dump supports and they can do their own boundary by combining the 2).

comment:5 Changed 7 years ago by robe

Type: enhancementpatch

comment:6 Changed 7 years ago by robe

amended docs at r11359

comment:7 Changed 7 years ago by robe

Keywords: history added

comment:8 Changed 7 years ago by strk

I'm seeing too many changes in lwgeom-geos connectors these days. May be worth some talk on the mailing list before it messes up too much ? Do I understand correctly that TRIANGLES are being threated like MULTILINESTRINGS when converted to GEOS ? Would it make more sense to convert to polygon ? Should we expose a Triangle geometry in GEOS C-API ?

comment:9 Changed 7 years ago by nw

I don't think that triangles are converted to geos at all. A look through the LWGEOM2GEOS() function doesn't seem to have any entry for a TRIANGLETYPE in the switch, so I think you'd get a call to lwerror() if you somehow managed to pass in a triangle. Curved geometries will fail also. Perhaps something else is converting them before a call to LWGEOM2GEOS().

I don't think GEOS has a triangle type, so you'd have to convert to a polygon if you were to do this.

comment:10 Changed 7 years ago by strk

ok then, I misread the patch, sorry for the noise.

Note: See TracTickets for help on using tickets.