[raster] compile warnings showing in 9.3

[robe]

I'm seeing these compile warnings for 2.1 on both Winnie and Debbie which I'm not seeing in prior versions of PostgreSQL

rt_pg.c: In function ‘RASTER_dumpAsPolygons’:
rt_pg.c:1106: warning: implicit declaration of function ‘heap_form_tuple’
rt_pg.c:1106: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_getGeotransform’:
rt_pg.c:1888: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_getPixelPolygons’:
rt_pg.c:3229: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_pixelOfValue’:
rt_pg.c:3523: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_summaryStats’:
rt_pg.c:5924: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_summaryStatsCoverage’:
rt_pg.c:6226: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_histogram’:
rt_pg.c:6498: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_histogramCoverage’:
rt_pg.c:7029: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_quantile’:
rt_pg.c:7280: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_quantileCoverage’:
rt_pg.c:7712: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_valueCount’:
rt_pg.c:7925: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_valueCountCoverage’:
rt_pg.c:8357: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_getGDALDrivers’:
rt_pg.c:9185: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_metadata’:
rt_pg.c:10120: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_bandmetadata’:
rt_pg.c:10373: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_rasterToWorldCoord’:
rt_pg.c:10478: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘RASTER_worldToRasterCoord’:
rt_pg.c:10579: warning: assignment makes pointer from integer without a cast
rt_pg.c: In function ‘rt_pg_error’:
rt_pg.c:13563: warning: function might be possible candidate for ‘gnu_printf’ format attribute
rt_pg.c:13563: warning: function might be possible candidate for ‘gnu_printf’ format attribute

[dustymugs]

The PostgreSQL devs have been doing some significant amount of work! Comparing my local copy of 9.1 to debbie's copy of 9.3 and I find that they've moved heap_form_tuple() from include/access/htup.h to a new file include/access/htup_details.h. Also, the devel docs regarding the use of heap_form_tuple() is still the same as before indicating the required inclusion of funcapi.h, something we already do. Looking at the dependency graph for funcapi.h on PostgreSQL's doxygen shows nothing linking to htup_details.h

It might be worth waiting to see PostgreSQL master settle down before trying to adapt to the new changes…

[robe]

Sound like a plan. How about we just setup a weekly job to download latest snapshot and recompile PostgreSQL 9.3 and regress 2.1 and we'll just monitor the craziness that ensues once a week.

[dustymugs]

Fixed the implicit declaration of heap_form_tuple() in raster and postgis in r10885.