Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1971 closed defect (fixed)

rtpostgis_upgrade_20_minor.sql:530: ERROR: syntax error at or near "DO"

Reported by: strk Owned by: pramsey
Priority: medium Milestone: PostGIS 2.1.0
Component: postgis Version: master
Keywords: Cc:

Description

Running make check against PostgreSQL 8.4 with PostGIS trunk triggers this error:

psql:/home/src/postgis/postgis/regress/00-regress-install/share/contrib/postgis/rtpostgis_upgrade_20_minor.sql:530: ERROR:  syntax error at or near "DO"
LINE 1: DO language 'plpgsql' $$

I'm guessing PostgreSQL 9.1 is required, but in that case we should bail out at configure time.

By the way, have you read the recent apologia requesting support for older systems ? I'm always happy to support older versions of dependencies… And I'm on Ubuntu 10.04, btw. http://blog.cleverelephant.ca/2012/08/postgis-apologia.html

Change History (6)

comment:1 by robe, 12 years ago

Resolution: wontfix
Status: newclosed

I took the conditiontal 8.4 check out. Remember we agreed, we aren't supporting 8.4 for 2.1, so we don't need 8.4 checks anymore.

comment:2 by robe, 12 years ago

BTW I'm against supporting old versions of PostgreSQL for newer releases of PostGIS if it requires us to put in hackish workarounds to support them. So yes I read and took it to heart and I say older OS maybe if not too much effort, but older PostgreSQL NO if it requires us to put in conditional logic in our code.

PostgreSQL group doesn't want us to support old PostgreSQL versions. They want people using their new stuff just as much as we want people using our new stuff. Bending over backwards to support Old PostgreSQL hurts everyone.

comment:3 by strk, 12 years ago

Resolution: wontfix
Status: closedreopened

I'm tweaking the ./configure script to encode the new dependency and was looking for a document officially stating them (including GEOS and proj and what not), but the README turned out being outdated as well.

Where's the official view on deps ?

Also a link on mailing list archives about the decisions would be nice to have

comment:4 by strk, 12 years ago

Resolution: fixed
Status: reopenedclosed

Ok, used the HTML manual to determine dependencies, updated the README and the ./configure script accordingly. With r10235, r10236 and r10237

comment:5 by robe, 12 years ago

FWIW, I've been documenting dependencies here: https://trac.osgeo.org/postgis/wiki/UsersWikiPostgreSQLPostGIS

Which I believe I have linked in the manual and user wiki front page. Here is the link on newsgroup where we voted: http://www.postgis.org/pipermail/postgis-devel/2012-May/020798.html http://www.postgis.org/pipermail/postgis-devel/2012-May/020906.html

Admittedly you were a bit of a hold out — but I think we outnumbered you: http://www.postgis.org/pipermail/postgis-devel/2012-May/020784.html

comment:6 by strk, 12 years ago

Sorry, no time to followup, I'm still trying to get out of the water after a system upgrade forced by the nice postgis developers >:-)

… seriously, I've been on Ubuntu 10.04 → 12.04 all day now, and haven't finished yet

Now dealing with PHPUNIT, changing interface between versions, needed for GEOS, needed for GDAL, needed for PostGIS rasters.

How much I like, dropping support for old versions ! sheeesh

Note: See TracTickets for help on using tickets.