Opened 12 years ago

Closed 12 years ago

#1608 closed task (fixed)

Sort out scripts versions

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description

Since we now have 3 scripts to deal with (core, topology, raster) I think it would make sense to handle syncing in a more robust way.

The current situation is we have a single library version (core) and a single scripts version (core). No version is embedded in raster library nor in raster or topology scripts.

It seems to me that a simple approach to the problem would be to have all objects share the same version, no matter what changes and what not. After all the idea is that you're always able to do minor upgrades between versions so you should always do that, no matter whether or not the scripts actually changed.

I should add that the current script version thing fails to detect if the scripts really changed as it misses included files.

Change History (6)

comment:1 by strk, 12 years ago

Owner: changed from pramsey to strk
Status: newassigned

comment:2 by strk, 12 years ago

r9304 unifies versions in the core, taking postgis_scripts_installed() and postgis_scripts_released() to show up major.minor.micro + svn revision.

comment:3 by strk, 12 years ago

Should we drop postgis_svn_revision() and merge into postgis_lib_version() instead ? I would…

comment:4 by strk, 12 years ago

r9306 adds postgis_topology_scripts_installed() and r9307 adds postgis_raster_scripts_installed() now we only miss the SVN revision in postgis_raster_version, thus the question in previous comment…

comment:5 by strk, 12 years ago

With r9309 we have SVN revision in raster lib version too. Here's an example query:

\x
select postgis_scripts_installed() as core_script, postgis_raster_scripts_installed() as raster_script, postgis_topology_scripts_installed() as topo_script, postgis_lib_version() || ' r' || postgis_svn_version() as core_lib, postgis_raster_lib_version() as raster_lib;
-[ RECORD 1 ]-+---------------------
core_script   | 2.0.0alpha7SVN r9303
raster_script | 2.0.0alpha7SVN r9305
topo_script   | 2.0.0alpha7SVN r9303
core_lib      | 2.0.0alpha7SVN r9308
raster_lib    | 2.0.0alpha7SVN r9308

Interesting mess isn't it ? :) Now on to the postgis_full_version() check.

comment:6 by strk, 12 years ago

Resolution: fixed
Status: assignedclosed

I'd call it done with r9310 Try postgis_full_version() after a scripts upgrade…

Note: See TracTickets for help on using tickets.