upgrade script failure: error can not change name of input parameter "new_srid"

[robe]

Get this error when trying to upgrade from alpha5 to alpha6 using

ALTER EXTENSION postgis UPDATE TO "2.0.0alpha6";

Haven't checked if similar issue with regular upgrade.

[robe]

Same issue with 9.0 build

I think its this function — we need to drop it first as part of upgrade

CREATE OR REPLACE FUNCTION UpdateGeometrySRID(catalogn_name varchar,schema_name varchar,table_name varchar,column_name varchar,new_srid_in integer)

[mwtoews]

This error stemmed from #1596. The last parameter in UpdateGeometrySRID, new_srid, was renamed to new_srid_in. The rational was to somewhat mimic AddGeometryColumn. This can be modified back, if required. (Another internal variable name like new_srid_mod would need to be used within UpdateGeometrySRID, since the IN parameters are CONST and this var may change to unknown_srid).

[mwtoews]

fix-up from #1596

[mwtoews]

If it is preferred to keep the old parameter names, use the attached patch.

[strk]

This is the kind of regression our testsuite would hardly ever get

[strk]

Changing again would mean that the upgrade will fail for anyone going from alpha6 to alpha7, but those going from alpha5 to alpha7 would be fine.

Better go with the drop, probably.

[strk]

Fixed with r9275