Opened 12 years ago

Closed 12 years ago

#1463 closed enhancement (wontfix)

postgis_restore.pl: be immune of argument names

Reported by: strk Owned by: pramsey
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description

When deciding which functions in a dump to keep and which ones to drop we look at function signatures. Now function signatures include argument name and so we might want to NOT consider those or our skip list would get even bigger than it currently is as we're adding argument names in 2.0.

One problem with this is that some typenames are two words long, making it difficult to say what's a typename and what's an argname:

 (a double precision, an integer, double precision, integer)

Change History (2)

comment:1 by strk, 12 years ago

ouch, add to the list things like:

VARIADIC constraints text[]

It is also to be noted that the existing DATA section of postgis_upgrade.pl already contains some signatures with type names.

comment:2 by strk, 12 years ago

Resolution: wontfix
Status: newclosed

Well, it turns out it is way too dangerous to attempt at doing this in a general way. We'll have to leave with arg names being part of a function signature and grow our skip list.

Note: See TracTickets for help on using tickets.