1.4 ST_Distance and ST_Dwithin doesn't handle collections correctly

[robe]

What steps will reproduce the problem?

1. Run the below

SELECT ST_Distance(g1,g2), ST_Dwithin(g1,g2,0.01), ST_AsEWKT(g2) FROM (SELECT ST_geomFromEWKT('LINESTRING(1 2, 2 4)') As g1, ST_Collect(ST_GeomFromEWKT('LINESTRING(0 0, -1 -1)'), ST_GeomFromEWKT('MULTIPOINT(1 2,2 3)')) As g2) As foo

What is the expected output? In 1.3.5 I get this

2.23606797749979;f;GEOMETRYCOLLECTION(LINESTRING(0 0,-1 -1),MULTIPOINT(1 2,2 3)) What do you see instead? In 1.4 I get this

ERROR: Unsupported geometry type: MultiPoint

[robe]

On closer inspection I'm guessing this is a bug we introduced when we tried to resolve the crashing bug for curved support in distance and that other cleanup thing I can't remember.

The problem seems to consistently happen in 1.4 if you have a collection that contains another geometry collection or a multi type geometry.

[robe]

<i>(No comment was entered for this change.)</i>

[post...@…]

Hallo

I found a bug in measures.c It could handle collections and mult as the first incomming geometry but not the second. I think this patch solves it /Nicklas Avén

[robe....@…]

​http://postgis.googlecode.com/issues/attachment?aid=8518513116142367017&name=st_distance_bugfix.patch

[pramsey]

Applied modified version to 1.3 branch at r3966, to trunk at r3967.

[robe]

This looks okay to me, but can't test against 1.3.6SVN since apparently that still crashes with curves and my 1.3.6 is very unhappy after the crash.