Opened 13 years ago

Closed 13 years ago

#1405 closed task (fixed)

Hudson should run make check RUNTESTFLAGS='-v'

Reported by: strk Owned by: chodgson
Priority: medium Milestone: PostGIS 2.0.0
Component: management Version: master
Keywords: Cc:

Description

By passing RUNTESTFLAGS='-v' to "make check" all failure should (theoretically) be printed on stdout.

Change History (4)

comment:1 by chodgson, 13 years ago

Resolution: fixed
Status: newclosed

I modified regress.sh, which is used for the majority of the regression tests (if not all) to include this parameter to make check. Haven't had a successful regression test since…

comment:2 by chodgson, 13 years ago

Resolution: fixed
Status: closedreopened

The raster "testapi" outputs some expected error messages, which means that we can't just grep all the output for "error"… was there some other error output that we need to catch that isn't being caught without the "-v"?

comment:3 by strk, 13 years ago

You don't have to grep anything, just use the return code from "make check" If it returns non-zero it failed, otherwise it succeeds.

Passing RUNTESTFLAGS=-v makes it so that details of failures (the diff) are printed on stdout, so you can grab just that as an additional detail to write in the email.

comment:4 by chodgson, 13 years ago

Resolution: fixed
Status: reopenedclosed

I've modified the regress script to now catch the return code from the make check call and output something which can be grep'd by the hudson script that calls it. Also removed another check from the hudson script which was broken. Hopefully we will catch all the failures and have minimal false positives after these changes. The output resulting from the "-v" option can now be seen in the console output from hudson.

Note: See TracTickets for help on using tickets.