Opened 11 years ago

Closed 11 years ago

#1390 closed defect (fixed)

postgis_upgrade.pl should skip postgis function comments

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: build/upgrade/install Version: master
Keywords: Cc:

Description

Comments are of the form:

COMMENT ON FUNCTION public.st_ymax(box3d) IS 'args: aGeomorBox2DorBox3D - Returns Y maxima of a bounding box 2d or 3d or a geometry.'

As a result, the restore process will overwrite the new ones if not skipped.

Change History (5)

comment:1 by strk, 11 years ago

The best way to fix this is by obtaining a log of a postgis_restore.pl run in presence of comments in the dump. You can get such log by passing the -v switch to postgis_restore.pl and redirecting its standard error to a file, then grep for 'KEEP.*COMMENT' into the log.

I don't have a dump with comments. Can make up one but one with comments from 1.4 and/or 1.5 would be even better.

comment:2 by strk, 11 years ago

Status: newassigned

I made one for 1.5 and the result is r8476 Will go on with 1.4 and then finally 2.0

comment:3 by strk, 11 years ago

Nothing more to add for a pg14 dump

comment:4 by strk, 11 years ago

I was wrong, fooled by not looking at the restore log. r8477 adds the ones from pg14, moving on to 2.0.0 comments

comment:5 by strk, 11 years ago

Resolution: fixed
Status: assignedclosed

r8478 adds comments in 2.0 including those for topology and raster, making the restore script reach the venerable size of 2600 lines (2300 of which being data)

Note: See TracTickets for help on using tickets.